Merge lp:~ted/ubuntu-app-launch/zg-no-error into lp:ubuntu-app-launch/15.10

Proposed by Ted Gould on 2015-05-27
Status: Merged
Approved by: Charles Kerr on 2015-06-05
Approved revision: 196
Merged at revision: 199
Proposed branch: lp:~ted/ubuntu-app-launch/zg-no-error
Merge into: lp:ubuntu-app-launch/15.10
Diff against target: 11 lines (+1/-1)
1 file modified
zg-report-app.c (+1/-1)
To merge this branch: bzr merge lp:~ted/ubuntu-app-launch/zg-no-error
Reviewer Review Type Date Requested Status
Charles Kerr (community) 2015-05-27 Approve on 2015-06-05
PS Jenkins bot (community) continuous-integration Approve on 2015-05-27
Review via email: mp+260297@code.launchpad.net

Commit message

Don't error on ZG failure

Description of the change

We're overreacting here. It seems that ZG will detect this error and clean up the dirty DB when it happens, so it's not a big deal. We should still report it, but it's not worth an entry in errors.u.c to track it.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'zg-report-app.c'
2--- zg-report-app.c 2014-09-10 14:54:01 +0000
3+++ zg-report-app.c 2015-05-27 13:53:48 +0000
4@@ -39,7 +39,7 @@
5 result = zeitgeist_log_insert_event_finish(ZEITGEIST_LOG(obj), res, &error);
6
7 if (error != NULL) {
8- g_error("Unable to submit Zeitgeist Event: %s", error->message);
9+ g_warning("Unable to submit Zeitgeist Event: %s", error->message);
10 g_error_free(error);
11 }
12

Subscribers

People subscribed via source and target branches