Code review comment for lp:~ted/ubuntu-app-launch/xmir-support

Revision history for this message
Christopher Townsend (townsend) wrote :

This was discussed on IRC, but I'll put it here as well for the record.

The crash seen in bug #1472097 is due to the '-rootless' option passed to Xmir. For a final solution, '-rootless' is desired, but short term, we need to figure out whether '-rootless' can be fixed in fairly quick manner or if it needs to be removed from this MP.

As this MP needs to land soon for PD, we need to figure out which option is best for the short term.

Aside from the '-rootless' issue, looks good and works well once I removed '-rootless' in my test.

review: Needs Information

« Back to merge proposal