Merge lp:~ted/ubuntu-app-launch/virtual-destructors into lp:ubuntu-app-launch

[Ted Gould]

Add missing virtual destructors

[Charles Kerr (charlesk)]

review: Approve

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:288
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/221/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1664/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1671
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1445/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1445/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1445/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1445/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1445/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1445/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/221/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'libubuntu-app-launch/helper.h'
--- libubuntu-app-launch/helper.h	2017-01-26 22:46:49 +0000
+++ libubuntu-app-launch/helper.h	2017-02-10 14:16:26 +0000
@@ -62,11 +62,9 @@
 */
 class Helper
 {
-    /*
-    protected:
-        Helper() = default;
-        virtual ~Helper() = default;
-           TODO: Next ABI break */
+protected:
+    Helper() = default;
+    virtual ~Helper() = default;
 
 public:
     /** \private */
@@ -93,11 +91,9 @@
     /** Running instance of a a Helper */
     class Instance
     {
-        /*
-            protected:
-                Instance() = default;
-                virtual ~Instance() = default;
-                   TODO: Next ABI break */
+    protected:
+        Instance() = default;
+        virtual ~Instance() = default;
 
     public:
         /** Check to see if this instance is running */

=== modified file 'libubuntu-app-launch/registry.h'
--- libubuntu-app-launch/registry.h	2017-01-24 00:09:09 +0000
+++ libubuntu-app-launch/registry.h	2017-02-10 14:16:26 +0000
@@ -187,8 +187,7 @@
 
     protected:
         Manager() = default;
-        /* virtual ~Manager() = default;
-           TODO: Next ABI break */
+        virtual ~Manager() = default;
     };
 
     /** Set the manager of applications, which gives permissions for them to