lp:~ted/ubuntu-app-launch/registry-cleanup

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntu-app-launch at revision 310

unity-api-1-bot: Approve (continuous-integration) on 2017-04-04

Charles Kerr (community): Approve on 2017-04-04

James Henstridge: Abstain on 2017-04-03

Diff: 4035 lines (+920/-965)

40 files modified

libubuntu-app-launch/app-store-base.cpp (+8/-8)
libubuntu-app-launch/app-store-base.h (+13/-15)
libubuntu-app-launch/app-store-legacy.cpp (+14/-18)
libubuntu-app-launch/app-store-legacy.h (+8/-15)
libubuntu-app-launch/app-store-libertine.cpp (+13/-17)
libubuntu-app-launch/app-store-libertine.h (+8/-15)
libubuntu-app-launch/app-store-snap.cpp (+19/-23)
libubuntu-app-launch/app-store-snap.h (+8/-15)
libubuntu-app-launch/application-impl-base.cpp (+2/-2)
libubuntu-app-launch/application-impl-base.h (+10/-10)
libubuntu-app-launch/application-impl-legacy.cpp (+8/-8)
libubuntu-app-launch/application-impl-legacy.h (+1/-1)
libubuntu-app-launch/application-impl-libertine.cpp (+8/-8)
libubuntu-app-launch/application-impl-libertine.h (+1/-1)
libubuntu-app-launch/application-impl-snap.cpp (+13/-13)
libubuntu-app-launch/application-impl-snap.h (+4/-4)
libubuntu-app-launch/application-info-desktop.cpp (+3/-3)
libubuntu-app-launch/application-info-desktop.h (+5/-3)
libubuntu-app-launch/application.cpp (+45/-34)
libubuntu-app-launch/helper-impl.h (+2/-2)
libubuntu-app-launch/helper.cpp (+15/-17)
libubuntu-app-launch/info-watcher-zg.cpp (+1/-1)
libubuntu-app-launch/info-watcher-zg.h (+1/-1)
libubuntu-app-launch/info-watcher.cpp (+16/-2)
libubuntu-app-launch/info-watcher.h (+10/-1)
libubuntu-app-launch/jobs-base.cpp (+98/-118)
libubuntu-app-launch/jobs-base.h (+33/-26)
libubuntu-app-launch/jobs-systemd.cpp (+312/-352)
libubuntu-app-launch/jobs-systemd.h (+6/-2)
libubuntu-app-launch/registry-impl.cpp (+34/-16)
libubuntu-app-launch/registry-impl.h (+52/-22)
libubuntu-app-launch/registry.cpp (+27/-49)
libubuntu-app-launch/registry.h (+6/-4)
tests/application-info-desktop.cpp (+2/-2)
tests/info-watcher-zg.cpp (+2/-3)
tests/jobs-base-test.cpp (+2/-2)
tests/jobs-systemd.cpp (+26/-22)
tests/libual-cpp-test.cc (+40/-49)
tests/list-apps.cpp (+6/-6)
tests/registry-mock.h (+38/-55)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1676361: keeper-service segfaults inside ubuntu::app_launch::helper_impls::Base::launch

Critical

Fix Released

Link a bug report

Related blueprints

328. By Ted Gould on 2017-04-04

Remove arbitrary change

327. By Ted Gould on 2017-04-04

Change around the zgWatcher and realize the test is really just a placeholder

326. By Ted Gould on 2017-04-04

Ensure the jobs-systemd tests have a legacy appstore to use

325. By Ted Gould on 2017-04-04

Fix zgwatcher setup

324. By Ted Gould on 2017-04-04

Clean up the handling of the ZG Watcher

323. By Ted Gould on 2017-04-04

Adapt tests to changes

322. By Ted Gould on 2017-04-04

Now that the Impl is ready at init we can get the bus then too

321. By Ted Gould on 2017-04-04

Switch App Stores over to using smart poitners

320. By Ted Gould on 2017-04-04

Switch the jobs over to smart pointers

319. By Ted Gould on 2017-04-04

Make it so that we don't set all the objects on init of Impl, just with setters and getters in the Registry object.