Code review comment for lp:~ted/ubuntu-app-launch/process-group-kill

Revision history for this message
Tyler Hicks (tyhicks) wrote :

While this should work for the purposes of bug 1303676, lets be sure we don't depend, from a security standpoint, on this change to kill all processes spawned by an application. An application could create another process group and move all of its processes to that group and this change would not kill those processes.

I don't think the intent of this change is to fully clean up, with 100% assurance, after an application. As long as that's the case, it looks good to me! :)

« Back to merge proposal