Merge lp:~ted/ubuntu-app-launch/primary-pid-no-app into lp:ubuntu-app-launch/16.10
Proposed by
Ted Gould
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | dobey | ||||
Approved revision: | 246 | ||||
Merged at revision: | 246 | ||||
Proposed branch: | lp:~ted/ubuntu-app-launch/primary-pid-no-app | ||||
Merge into: | lp:ubuntu-app-launch/16.10 | ||||
Diff against target: |
61 lines (+7/-5) 2 files modified
libubuntu-app-launch/ubuntu-app-launch.cpp (+5/-5) tests/libual-test.cc (+2/-0) |
||||
To merge this branch: | bzr merge lp:~ted/ubuntu-app-launch/primary-pid-no-app | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
unity-api-1-bot | continuous-integration | Needs Fixing | |
dobey (community) | Approve | ||
Review via email: mp+303940@code.launchpad.net |
Commit message
Use at() instead of operator[]() so that we get an exception on bounds checking
Description of the change
Didn't realize that vector's operator[]() doesn't do any bounds checking and it just crashes. Which is stupid, but supported by the documentation. Switching to use at() that does do bounds checking and throws an exception that we can catch as we'd expected.
To post a comment you must log in.
FAILED: Continuous integration, rev:246 /jenkins. canonical. com/unity- api-1/job/ lp-ubuntu- app-launch- ci/69/ /jenkins. canonical. com/unity- api-1/job/ build/487/ console /jenkins. canonical. com/unity- api-1/job/ build-0- fetch/493 /jenkins. canonical. com/unity- api-1/job/ build-1- sourcepkg/ release= vivid+overlay/ 398 /jenkins. canonical. com/unity- api-1/job/ build-1- sourcepkg/ release= xenial+ overlay/ 398 /jenkins. canonical. com/unity- api-1/job/ build-1- sourcepkg/ release= yakkety/ 398 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= vivid+overlay/ 328/console /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 328 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 328/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= yakkety/ 328 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= yakkety/ 328/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= vivid+overlay/ 328/console /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 328 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 328/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= yakkety/ 328 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= yakkety/ 328/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= vivid+overlay/ 328/console /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 328 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 328/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= yakkety/ 328 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= yakkety/ 328/artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /jenkins. canonical. com/unity- api-1/job/ lp-ubuntu- app-launch- ci/69/rebuild
https:/