Merge lp:~ted/ubuntu-app-launch/no-error-on-root-processes into lp:ubuntu-app-launch/15.04

[Ted Gould]

Remove reporting a recoverable problem on cgmanager

We can't do it, so don't try, just gonna cause heartache.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:179
http://jenkins.qa.ubuntu.com/job/upstart-app-launch-ci/309/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-vivid-amd64-ci/4/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-vivid-armhf-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-vivid-i386-ci/4

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/upstart-app-launch-ci/309/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:179
http://jenkins.qa.ubuntu.com/job/upstart-app-launch-ci/310/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-vivid-amd64-ci/5/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-vivid-armhf-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/upstart-app-launch-vivid-i386-ci/5

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/upstart-app-launch-ci/310/rebuild

review: Needs Fixing (continuous-integration)

[Charles Kerr (charlesk)]

LGTM.

The amd64 failure doesn't appear to be related to this MP

review: Approve

=== modified file 'helpers-shared.c'
--- helpers-shared.c	2014-11-18 21:10:34 +0000
+++ helpers-shared.c	2014-11-21 20:44:55 +0000
@@ -98,22 +98,6 @@
 	return keyfile;
 }
 
-/* Quick way to get the pid of cgmanager to report a bug on it */
-static GPid
-discover_cgmanager_pid (void)
-{
-	gchar * outbuf = NULL;
-	GPid outpid = 0;
-	
-	if (g_spawn_command_line_sync("pidof cgmanager", &outbuf, NULL, NULL, NULL)) {
-		outpid = g_ascii_strtoull(outbuf, NULL, 10);
-	}
-
-	g_free(outbuf);
-
-	return outpid;
-}
-
 /* Structure to handle data for the cgmanager connection
    set of callbacks */
 typedef struct {
@@ -127,16 +111,10 @@
 static gboolean
 cgroup_manager_connection_timeout_cb (gpointer data)
 {
-	GPid cgmanager_pid = 0;
 	cgm_connection_t * connection = (cgm_connection_t *)data;
 
 	g_cancellable_cancel(connection->cancel);
 
-	cgmanager_pid = discover_cgmanager_pid();
-	if (cgmanager_pid != 0) {
-		report_recoverable_problem("ubuntu-app-launch-cgmanager-connection-timeout", cgmanager_pid, FALSE, NULL);
-	}
-
 	return G_SOURCE_CONTINUE;
 }