Merge lp:~ted/pyjuju/bazaar-revision into lp:pyjuju
Proposed by
Ted Gould
Status: | Work in progress |
---|---|
Proposed branch: | lp:~ted/pyjuju/bazaar-revision |
Merge into: | lp:pyjuju |
Diff against target: |
26 lines (+9/-0) 1 file modified
juju/charm/directory.py (+9/-0) |
To merge this branch: | bzr merge lp:~ted/pyjuju/bazaar-revision |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gustavo Niemeyer | Disapprove | ||
Kapil Thangavelu (community) | Disapprove | ||
Review via email: mp+110596@code.launchpad.net |
Description of the change
If there is no revision specified use the Bazaar revision if the charm is stored in a Bazaar repository.
I'm not sure how to test this, but I tried the code in ipython and it seems to work well enough. I'm posting mostly for feedback on the concept.
To post a comment you must log in.
Hi Ted.
I *love* this idea. I've always felt the explicit revision file was too clumsy.
I do think there is a strong desire to avoid tying to bzr for charms though, so you may see push back there.
Either way, this would need some documentation to go with it.