libindicate

Merge lp:~ted/libindicate/mem-leak into lp:libindicate/0.6

  1. mem-leak
  2. Merge into trunk
Proposed by Ted Gould
Status: Rejected
Rejected by: Ted Gould
Proposed branch: lp:~ted/libindicate/mem-leak
Merge into: lp:libindicate/0.6
Diff against target: 26 lines (+3/-0)
1 file modified
libindicate/listener.c (+3/-0)
To merge this branch: bzr merge lp:~ted/libindicate/mem-leak
Reviewer Review Type Date Requested Status
Conor Curran (community) Approve
Review via email: mp+47086@code.launchpad.net

Description of the change

Memory leak patch from ~hyperair recorded on bug 690668

To post a comment you must log in.
Revision history for this message
Conor Curran (cjcurran) :
review: Approve
Revision history for this message
Ted Gould (ted) wrote :

Rejected because of CA.

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libindicate/listener.c'
2--- libindicate/listener.c 2011-01-13 22:43:05 +0000
3+++ libindicate/listener.c 2011-01-21 19:57:22 +0000
4@@ -1116,6 +1116,7 @@
5
6 if (error != NULL) {
7 g_warning("Listener display caused an error: %s", error->message);
8+ g_error_free(error);
9 }
10 return;
11 }
12@@ -1145,6 +1146,7 @@
13
14 if (error != NULL) {
15 g_warning("Listener displayed caused an error: %s", error->message);
16+ g_error_free(error);
17 }
18 return;
19 }
20@@ -1209,6 +1211,7 @@
21 g_warning("Really? This can't happen. WTF! %s", g_variant_get_type_string(prop));
22 }
23
24+ g_variant_unref(prop);
25 return;
26 }
27

Subscribers

People subscribed via source and target branches

to all changes: