Merge lp:~ted/libertine/ld-library-path-lives-on into lp:libertine

[Ted Gould]

Remove 'LD_LIBRARY_PATH' from the env blacklist

When libertine is in a snap, we really need to keep the LD_LIBRARY_PATH around as it is the only way that we can find the libraries. They're everywhere otherwise.

[Libertine CI Bot (libertine-ci-bot)]

PASSED: Continuous integration, rev:342
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/243/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/libertine/job/build/508
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=default/401
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=default/401
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=zesty,testname=default/401
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=vivid+overlay,testname=default/401
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=xenial+overlay,testname=default/401
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=zesty,testname=default/401
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-0-fetch/518
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=vivid+overlay/502
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=vivid+overlay/502/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/502
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/502/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=zesty/502
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=zesty/502/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=vivid+overlay/502
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=vivid+overlay/502/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/502
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/502/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=zesty/502
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=zesty/502/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/243/rebuild

review: Approve (continuous-integration)

[Christopher Townsend (townsend)]

Yep, I was running into this issue too. You beat me to the MP:)

review: Approve

=== modified file 'python/libertine/launcher/config.py'
--- python/libertine/launcher/config.py	2016-10-28 16:33:02 +0000
+++ python/libertine/launcher/config.py	2016-12-01 05:09:35 +0000
@@ -182,7 +182,7 @@
         environ = os.environ.copy()
 
         # remove problematic environment variables
-        for e in ['QT_QPA_PLATFORM', 'LD_LIBRARY_PATH', 'FAKECHROOT_BASE', 'FAKECHROOT_CMD_SUBST']:
+        for e in ['QT_QPA_PLATFORM', 'FAKECHROOT_BASE', 'FAKECHROOT_CMD_SUBST']:
             if e in environ:
                 del environ[e]