Merge lp:~ted/libdbusmenu/no-spam-for-seb into lp:libdbusmenu/0.5

Proposed by Ted Gould
Status: Merged
Approved by: Michael Terry
Approved revision: 271
Merged at revision: 272
Proposed branch: lp:~ted/libdbusmenu/no-spam-for-seb
Merge into: lp:libdbusmenu/0.5
Diff against target: 13 lines (+3/-1)
1 file modified
libdbusmenu-gtk/parser.c (+3/-1)
To merge this branch: bzr merge lp:~ted/libdbusmenu/no-spam-for-seb
Reviewer Review Type Date Requested Status
Michael Terry Approve
Review via email: mp+53495@code.launchpad.net

Description of the change

Make a warning that happens really pretty normally not print something to commandline users.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-gtk/parser.c'
2--- libdbusmenu-gtk/parser.c 2011-03-14 20:01:04 +0000
3+++ libdbusmenu-gtk/parser.c 2011-03-15 18:04:28 +0000
4@@ -124,7 +124,9 @@
5 DbusmenuMenuitem *
6 dbusmenu_gtk_parse_get_cached_item (GtkWidget * widget)
7 {
8- g_return_val_if_fail(GTK_IS_MENU_ITEM(widget), NULL);
9+ if (!GTK_IS_MENU_ITEM(widget)) {
10+ return NULL;
11+ }
12 return DBUSMENU_MENUITEM(g_object_get_data(G_OBJECT(widget), CACHED_MENUITEM));
13 }
14

Subscribers

People subscribed via source and target branches