Merge lp:~ted/lazr-js/annoying-debug-message into lp:lazr-js

[Ted Gould]

Everytime I do an lp-propose-merge I get this annoying debug message:

** Message: console message: https://code.edge.launchpad.net/+icing/rev11582/build/launchpad.js @19: loading lazr.activator

This bugs me. I think this branch fixes it. Please apply quickly, for as soon as I close this text editor it will come again!

[Paul Hummer (rockstar)]

review: Approve

[Paul Hummer (rockstar)]

I see this, not sure why it didn't get landed. lazr-js has been abandoned by all but the Launchpad team, and it seems they aren't really updating or maintaining lazr-js, so even if it landed, it wouldn't actually fix the bug... Sorry.

[Deryck Hodge (deryck)]

Paul, this is patently not true and you should know that. Especially given how much the two of us talk about js and lazr-js everyday. :-) You could have pinged me and said "hey, did you see this?"

This didn't land due to an error on my part. I wasn't subscribed correctly as I thought. I'll merge the branch and roll a new lazr-js.

I agree most everyone has abandoned lazr-js in Canonical except Launchpad. But we (at least me) are still actively applying bug fixes and updating lazr-js. We've had a few updates since this bug fix. This was just overlooked, and I'm really sorry about that, Ted. Shouldn't happen again.

As a general rule, we should never do Y.log in production code. I also agree the better log term fix is to get off lazr-js. But the fix is trivial to apply and yeilds quieter consoles in the near term.

review: Approve (code)

=== modified file 'src-js/lazrjs/activator/activator.js'
--- src-js/lazrjs/activator/activator.js	2010-04-13 13:02:44 +0000
+++ src-js/lazrjs/activator/activator.js	2010-09-21 18:17:44 +0000
@@ -2,8 +2,6 @@
 
 YUI.add('lazr.activator', function(Y) {
 
-Y.log('loading lazr.activator');
-
 var ACTIVATOR     = 'activator',
 
     // Local aliases