Merge lp:~ted/indicator-sound/upstart-job into lp:indicator-sound/14.04

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 360
Merged at revision: 402
Proposed branch: lp:~ted/indicator-sound/upstart-job
Merge into: lp:indicator-sound/14.04
Diff against target: 115 lines (+58/-21)
5 files modified
.bzrignore (+1/-1)
data/CMakeLists.txt (+37/-17)
data/indicator-sound.conf.in (+11/-0)
data/indicator-sound.desktop.in (+9/-0)
data/indicator-sound.service.in (+0/-3)
To merge this branch: bzr merge lp:~ted/indicator-sound/upstart-job
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Charles Kerr (community) Approve
Review via email: mp+192987@code.launchpad.net

This proposal supersedes a proposal from 2013-07-12.

Description of the change

Switching around the config files.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote : Posted in a previous version of this proposal

Needs to be synced with pete's cmake changes.

Ted, why didn't you do that when you submitted this MP in mid-July? ;-)

review: Needs Fixing
Revision history for this message
Ted Gould (ted) wrote : Posted in a previous version of this proposal

On Tue, 2013-08-27 at 14:42 +0000, Charles Kerr wrote:

> Needs to be synced with pete's cmake changes.
>
> Ted, why didn't you do that when you submitted this MP in mid-July? ;-)

Sorry forgot to push the last version ;-) Fixed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
lp:~ted/indicator-sound/upstart-job updated
360. By Ted Gould

Forgot a var

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2013-08-16 03:58:55 +0000
3+++ .bzrignore 2013-10-29 00:54:30 +0000
4@@ -1,7 +1,7 @@
5 /po/POTFILES
6 /po/stamp-it
7
8-/data/indicator-sound.service
9+/data/indicator-sound.conf
10
11 /src/indicator-sound-service
12 /src/indicator_sound_service_vala.stamp
13
14=== modified file 'data/CMakeLists.txt'
15--- data/CMakeLists.txt 2013-08-16 03:13:41 +0000
16+++ data/CMakeLists.txt 2013-10-29 00:54:30 +0000
17@@ -17,23 +17,43 @@
18 )
19
20 ###########################
21-# Dbus Service
22-###########################
23-
24-set(
25- INDICATOR_SOUND_SERVICE
26- "${CMAKE_CURRENT_BINARY_DIR}/indicator-sound.service"
27-)
28-
29-configure_file(
30- "indicator-sound.service.in"
31- ${INDICATOR_SOUND_SERVICE}
32- @ONLY
33-)
34-
35-install(
36- FILES "${INDICATOR_SOUND_SERVICE}"
37- DESTINATION "${CMAKE_INSTALL_DATADIR}/dbus-1/services/"
38+# Upstart Job
39+###########################
40+
41+set(
42+ INDICATOR_SOUND_CONF
43+ "${CMAKE_CURRENT_BINARY_DIR}/indicator-sound.conf"
44+)
45+
46+configure_file(
47+ "indicator-sound.conf.in"
48+ ${INDICATOR_SOUND_CONF}
49+ @ONLY
50+)
51+
52+install(
53+ FILES "${INDICATOR_SOUND_CONF}"
54+ DESTINATION "${CMAKE_INSTALL_DATADIR}/upstart/sessions/"
55+)
56+
57+###########################
58+# XDG Autostart
59+###########################
60+
61+set(
62+ INDICATOR_SOUND_XDG_AUTOSTART
63+ "${CMAKE_CURRENT_BINARY_DIR}/indicator-sound.desktop"
64+)
65+
66+configure_file(
67+ "indicator-sound.desktop.in"
68+ ${INDICATOR_SOUND_XDG_AUTOSTART}
69+ @ONLY
70+)
71+
72+install(
73+ FILES "${INDICATOR_SOUND_XDG_AUTOSTART}"
74+ DESTINATION "/etc/xdg/autostart"
75 )
76
77 ###########################
78
79=== added file 'data/indicator-sound.conf.in'
80--- data/indicator-sound.conf.in 1970-01-01 00:00:00 +0000
81+++ data/indicator-sound.conf.in 2013-10-29 00:54:30 +0000
82@@ -0,0 +1,11 @@
83+description "Indicator Sound Backend"
84+
85+# Want to move to indicator-services-[start|end], but that's not all
86+# there yet. Use the signals that exist today for now.
87+
88+start on indicators-loaded or indicator-services-start
89+stop on desktop-end or indicator-services-end
90+
91+respawn
92+
93+exec @CMAKE_INSTALL_FULL_LIBEXECDIR@/indicator-sound/indicator-sound-service
94
95=== added file 'data/indicator-sound.desktop.in'
96--- data/indicator-sound.desktop.in 1970-01-01 00:00:00 +0000
97+++ data/indicator-sound.desktop.in 2013-10-29 00:54:30 +0000
98@@ -0,0 +1,9 @@
99+[Desktop Entry]
100+Type=Application
101+Name=Indicator Sound
102+Exec=@CMAKE_INSTALL_FULL_LIBEXECDIR@/indicator-sound/indicator-sound-service
103+NotShowIn=Unity;
104+NoDisplay=true
105+StartupNotify=false
106+Terminal=false
107+
108
109=== removed file 'data/indicator-sound.service.in'
110--- data/indicator-sound.service.in 2013-08-16 03:58:55 +0000
111+++ data/indicator-sound.service.in 1970-01-01 00:00:00 +0000
112@@ -1,3 +0,0 @@
113-[D-BUS Service]
114-Name=com.canonical.indicator.sound
115-Exec=@CMAKE_INSTALL_FULL_LIBEXECDIR@/indicator-sound/indicator-sound-service

Subscribers

People subscribed via source and target branches