Merge lp:~ted/indicator-sound/lp1381871-no-initial-value-for-utopic into lp:indicator-sound/14.10

[Ted Gould]

service.vala: don't call set_volume unnecessarily

The allow-amplified-volume setting is bound to a property on the service with the same name. GSettings always sets the target property when the binding is created. The property setter calls set_volume() unconditionally, which lead to a call on every startup of indicator-sound. That wasn't a problem until set_volume() started emitting a notification for volume changes...

service.vala: don't call set_volume unnecessarily

The allow-amplified-volume setting is bound to a property on the service with the same name. GSettings always sets the target property when the binding is created. The property setter calls set_volume() unconditionally, which lead to a call on every startup of indicator-sound. That wasn't a problem until set_volume() started emitting a notification for volume changes...

Fix this by only updating the property when the underlying value has actually changed.

[lp:~ted/indicator-sound/lp1381871-no-initial-value-for-utopic]

461. By Ted Gould on 2014-10-16

Align with trunk to prepare for landing there

462. By Ted Gould on 2014-10-16

No RTM changelog entries in Utopic

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:462
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/160/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-utopic-amd64-ci/27
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-utopic-armhf-ci/27
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-utopic-armhf-ci/27/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/160/rebuild

review: Approve (continuous-integration)

Unmerged revisions

462. By Ted Gould on 2014-10-16

No RTM changelog entries in Utopic

461. By Ted Gould on 2014-10-16

Align with trunk to prepare for landing there

460. By Lars Karlitski on 2014-10-16

service.vala: don't call set_volume unnecessarily

The allow-amplified-volume setting is bound to a property on the service with
the same name. GSettings always sets the target property when the binding is
created. The property setter calls set_volume() unconditionally, which lead to
a call on every startup of indicator-sound. That wasn't a problem until
set_volume() started emitting a notification for volume changes...

Fix this by only updating the property when the underlying value has actually
changed.

459. By PS Jenkins bot on 2014-10-15

Releasing 12.10.2+14.10.20141015.5~rtm-0ubuntu1

458. By Ted Gould on 2014-10-15

Warn on high audio levels when using headphones Fixes: 1373404
Approved by: Mirco Müller

457. By Ted Gould on 2014-10-15

Show notifications on volume change Fixes: 1378564, 1378961

=== modified file 'src/service.vala'
--- src/service.vala	2014-10-16 16:12:54 +0000
+++ src/service.vala	2014-10-16 16:12:54 +0000
@@ -131,6 +131,9 @@
 		}
 
 		set {
+			if (this.allow_amplified_volume == value)
+				return;
+
 			if (value) {
 				/* from pulse/volume.h: #define PA_VOLUME_UI_MAX (pa_sw_volume_from_dB(+11.0)) */
 				this.max_volume = (double)PulseAudio.Volume.sw_from_dB(11.0) / PulseAudio.Volume.NORM;