Merge lp:~ted/indicator-sound/lp1358340-greeter-data into lp:indicator-sound/15.04

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 461
Merged at revision: 461
Proposed branch: lp:~ted/indicator-sound/lp1358340-greeter-data
Merge into: lp:indicator-sound/15.04
Diff against target: 33 lines (+26/-0)
1 file modified
tests/manual (+26/-0)
To merge this branch: bzr merge lp:~ted/indicator-sound/lp1358340-greeter-data
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Antti Kaijanmäki Pending
Review via email: mp+240207@code.launchpad.net

This proposal supersedes a proposal from 2014-10-31.

Commit message

Ensure the greeter menu matches whether song metadata should be shown, and update the metadata based on the new setting.

Description of the change

Listen to the values in accounts service as it's now where all those values are stored. Changes both exporting the song data to AS as well as how our local instance of the greeter menu is shown.

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote : Posted in a previous version of this proposal

In silo 13 with a few other changes.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote : Posted in a previous version of this proposal

LGTM.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/manual'
2--- tests/manual 2014-01-31 20:09:51 +0000
3+++ tests/manual 2014-10-31 02:49:30 +0000
4@@ -22,3 +22,29 @@
5 <dd>The menu is populated with items</dd>
6 </dl>
7
8+Test-case indicator-sound/unity8-embedded-greeter
9+<dl>
10+ <dt>NOTE: Only works with embedded greeter, split greeter will require modifications to this test</dt>
11+ <dt>Ensure System Settings is set to "Show Messages on Greeter"</dt>
12+ <dt>Play a song in the media player</dt>
13+ <dd>The song should be heard</dd>
14+ <dd>There should be an entry in the sound menu with the meta data for the song being played</dd>
15+ <dt>Go to the greeter. This can be done by hitting the lock button twice.</dt>
16+ <dt>Ensure the sound menu has song meta data</dt>
17+ <dd>There should be an entry in the sound menu with the meta data for the song being played</dd>
18+ <dt>Pause the song in the greeter</dt>
19+ <dd>The song should stop playing</dd>
20+ <dt>Resume the song in the greeter</dt>
21+ <dd>The song should continue to play</dd>
22+ <dt>Disable System Settings value "Show Messages on Greeter"</dt>
23+ <dt>Ensure the sound menu has song meta data</dt>
24+ <dd>There should be an entry in the sound menu with the meta data for the song being played</dd>
25+ <dt>Go to the greeter. This can be done by hitting the lock button twice.</dt>
26+ <dt>Ensure the sound menu does not have song meta data</dt>
27+ <dd>There should be an entry for the player but it should have no information on the song being played</dd>
28+ <dt>Pause the song in the greeter</dt>
29+ <dd>The song should stop playing</dd>
30+ <dt>Resume the song in the greeter</dt>
31+ <dd>The song should continue to play</dd>
32+</dl>
33+

Subscribers

People subscribed via source and target branches