Code review comment for lp:~ted/indicator-sound/greeter-control

Revision history for this message
Ted Gould (ted) wrote :

 * Is Recommends sufficient for accountsservice? Surely it's a Depends now...?

I left it as a recommends just because we wouldn't *die* without it. I'd go either way, I figured the only thing we *needed* was the lib which gets pulled in by linking.

* In GreeterBroadcast, RequestApplicationStart(), RequestHomeShown(), StartApplication(),
   ShowHome() appear to be unused. Is there another branch waiting to be stacked on top
   of this one? Otherwise, these unused methods/signals should be removed

Fixed. r461. I commented them in case someone wanted to steal this Vala code in the future.

 * In accounts-service-user, probably ought to Warn() if username != g_get_user_name()
   instead of returning silently... if that argument's wrong, something's gone wrong
   in MediaPlayerListGreeter

Those are the signals that come off the system bus, so those events can be targeted at another user session that is also running at the same time. So it can be normal that we'd get ones that aren't for us.

« Back to merge proposal