Merge lp:~ted/indicator-sound/extreme-volume-warning into lp:indicator-sound/14.10
Proposed by
Ted Gould
Status: | Superseded | ||||||||
---|---|---|---|---|---|---|---|---|---|
Proposed branch: | lp:~ted/indicator-sound/extreme-volume-warning | ||||||||
Merge into: | lp:indicator-sound/14.10 | ||||||||
Prerequisite: | lp:~ted/indicator-sound/synchronous-notification | ||||||||
Diff against target: |
263 lines (+139/-15) 4 files modified
src/service.vala (+16/-0) src/sound-menu.vala (+39/-1) src/volume-control.vala (+66/-14) tests/manual (+18/-0) |
||||||||
To merge this branch: | bzr merge lp:~ted/indicator-sound/extreme-volume-warning | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Kerr (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
This proposal has been superseded by a proposal from 2014-10-31.
Commit message
Warn on high audio levels when using headphones
Description of the change
Both a notification change and a menu item for showing that there is high volume.
To post a comment you must log in.
Unmerged revisions
- 485. By Ted Gould
-
Make sure to check the item in the loop
- 484. By Ted Gould
-
Removing the remove code that was supposed to be removed earlier
- 483. By Ted Gould
-
Commenting out the sound for now
- 482. By Ted Gould
-
Make volume icons match the panel icons
- 481. By Ted Gould
-
Found other notification
- 480. By Ted Gould
-
Remove volume text from manual test
- 479. By Ted Gould
-
Get propery property name
- 478. By Ted Gould
-
Check more precisely the valid roles
- 477. By Mirco Müller <email address hidden>
-
Make High-volume text work correctly
- 476. By Ted Gould
-
Merge trunk
Ted, I think you can drop this branch. For fixing LP: #1373404 I've the more fitting solution with a patch to lp:unity-settings-daemon, which is the one process triggering volume- notifications upon hardware multi-media-keys already.
My branch lp:~macslow/unity-settings-daemon/max-volume-notification-warning does also fully comply with the dedicated design for the hig-volume-warning.