Merge lp:~ted/indicator-session/log-and-name into lp:indicator-session/0.1

Proposed by Ted Gould
Status: Merged
Merged at revision: 133
Proposed branch: lp:~ted/indicator-session/log-and-name
Merge into: lp:indicator-session/0.1
Diff against target: 104 lines (+43/-10)
6 files modified
AUTHORS (+2/-2)
ChangeLog (+2/-0)
Makefile.am (+25/-0)
data/Makefile.am (+1/-2)
data/indicator-users.service.in (+0/-3)
src/Makefile.am (+13/-3)
To merge this branch: bzr merge lp:~ted/indicator-session/log-and-name
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+46504@code.launchpad.net

Description of the change

Cleaning up the build and adding a log domain.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

 review approve

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'AUTHORS'
2--- AUTHORS 2009-09-24 00:14:01 +0000
3+++ AUTHORS 2011-01-17 17:19:51 +0000
4@@ -1,2 +1,2 @@
5-Ted Gould <ted@canonical.com>
6-Cody Russell <crussell@canonical.com>
7+# Generated by Makefile
8+
9
10=== modified file 'ChangeLog'
11--- ChangeLog 2008-12-05 03:13:41 +0000
12+++ ChangeLog 2011-01-17 17:19:51 +0000
13@@ -0,0 +1,2 @@
14+# Generated by Makefile
15+
16
17=== modified file 'Makefile.am'
18--- Makefile.am 2010-03-04 02:47:35 +0000
19+++ Makefile.am 2011-01-17 17:19:51 +0000
20@@ -8,3 +8,28 @@
21
22 DISTCHECK_CONFIGURE_FLAGS = --enable-localinstall
23
24+dist-hook:
25+ @if test -d "$(top_srcdir)/.bzr"; \
26+ then \
27+ echo Creating ChangeLog && \
28+ ( cd "$(top_srcdir)" && \
29+ echo '# Generated by Makefile. Do not edit.'; echo; \
30+ $(top_srcdir)/missing --run bzr log --gnu-changelog ) > ChangeLog.tmp \
31+ && mv -f ChangeLog.tmp $(top_distdir)/ChangeLog \
32+ || (rm -f ChangeLog.tmp; \
33+ echo Failed to generate ChangeLog >&2 ); \
34+ else \
35+ echo Failed to generate ChangeLog: not a branch >&2; \
36+ fi
37+ @if test -d "$(top_srcdir)/.bzr"; \
38+ then \
39+ echo Creating AUTHORS && \
40+ ( cd "$(top_srcdir)" && \
41+ echo '# Generated by Makefile. Do not edit.'; echo; \
42+ $(top_srcdir)/missing --run bzr log --long --levels=0 | grep -e "^\s*author:" -e "^\s*committer:" | cut -d ":" -f 2 | cut -d "<" -f 1 | sort -u) > AUTHORS.tmp \
43+ && mv -f AUTHORS.tmp $(top_distdir)/AUTHORS \
44+ || (rm -f AUTHORS.tmp; \
45+ echo Failed to generate AUTHORS >&2 ); \
46+ else \
47+ echo Failed to generate AUTHORS: not a branch >&2; \
48+ fi
49
50=== modified file 'data/Makefile.am'
51--- data/Makefile.am 2009-12-24 19:24:54 +0000
52+++ data/Makefile.am 2011-01-17 17:19:51 +0000
53@@ -1,8 +1,7 @@
54 SUBDIRS = icons
55
56 dbus_servicesdir = $(DBUSSERVICEDIR)
57-service_in_files = indicator-users.service.in \
58- indicator-session.service.in
59+service_in_files = indicator-session.service.in
60 dbus_services_DATA = $(service_in_files:.service.in=.service)
61
62 %.service: %.service.in
63
64=== removed file 'data/indicator-users.service.in'
65--- data/indicator-users.service.in 2011-01-14 03:07:18 +0000
66+++ data/indicator-users.service.in 1970-01-01 00:00:00 +0000
67@@ -1,3 +0,0 @@
68-[D-BUS Service]
69-Name=com.canonical.indicator.users
70-Exec=@libexecdir@/indicator-users-service
71
72=== modified file 'src/Makefile.am'
73--- src/Makefile.am 2011-01-11 16:48:07 +0000
74+++ src/Makefile.am 2011-01-17 17:19:51 +0000
75@@ -15,7 +15,10 @@
76 dbus-shared-names.h \
77 dbusmenu-shared.h \
78 users-service-client.h
79-libsession_la_CFLAGS = $(APPLET_CFLAGS) -Wall -Werror
80+libsession_la_CFLAGS = \
81+ $(APPLET_CFLAGS) \
82+ -Wall -Werror \
83+ -DG_LOG_DOMAIN=\"Indicator-Session\"
84 libsession_la_LIBADD = $(APPLET_LIBS)
85 libsession_la_LDFLAGS = -module -avoid-version
86
87@@ -90,8 +93,15 @@
88 users-service-dbus.h \
89 users-service-dbus.c \
90 users-service-marshal.c
91-indicator_session_service_CFLAGS = $(SESSIONSERVICE_CFLAGS) $(GCONF_CFLAGS) -DLIBEXECDIR=\"$(libexecdir)\" -Wall -Werror
92-indicator_session_service_LDADD = $(SESSIONSERVICE_LIBS) $(GCONF_LIBS)
93+indicator_session_service_CFLAGS = \
94+ $(SESSIONSERVICE_CFLAGS) \
95+ $(GCONF_CFLAGS) \
96+ -DLIBEXECDIR=\"$(libexecdir)\" \
97+ -Wall -Werror \
98+ -DG_LOG_DOMAIN=\"Indicator-Session\"
99+indicator_session_service_LDADD = \
100+ $(SESSIONSERVICE_LIBS) \
101+ $(GCONF_LIBS)
102
103 #################
104 # GTK Logout Stuff

Subscribers

People subscribed via source and target branches