Merge lp:~ted/indicator-printers/systemd-unit into lp:indicator-printers

Proposed by Martin Pitt
Status: Merged
Approved by: Martin Pitt
Approved revision: 76
Merged at revision: 75
Proposed branch: lp:~ted/indicator-printers/systemd-unit
Merge into: lp:indicator-printers
Diff against target: 90 lines (+38/-2)
5 files modified
configure.ac (+6/-2)
data/Makefile.am (+21/-0)
data/indicator-printers.override (+1/-0)
data/indicator-printers.service.in (+8/-0)
debian/control (+2/-0)
To merge this branch: bzr merge lp:~ted/indicator-printers/systemd-unit
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+309357@code.launchpad.net

Commit message

Add systemd unit

Description of the change

Last indicator that needs porting!

To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Works fine, aside from unity-panel-service needing to actually pull it in (will put up a unity MP for that). LGTM, thanks Ted!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2014-02-20 16:06:20 +0000
3+++ configure.ac 2016-10-26 14:48:15 +0000
4@@ -52,9 +52,13 @@
5 AC_MSG_ERROR([could not find cups-config])
6 fi
7 AC_CHECK_HEADER(cups/cups.h,,AC_MSG_ERROR([could not find cups.h]))
8-SERVICE_CFLAGS+=`$CUPS_CONFIG --cflags`
9-SERVICE_LIBS+=`$CUPS_CONFIG --libs`
10+CUPS_CFLAGS+=`$CUPS_CONFIG --cflags`
11+CUPS_LIBS+=`$CUPS_CONFIG --libs`
12+SERVICE_CFLAGS="$SERVICE_CFLAGS $CUPS_CFLAGS"
13+SERVICE_LIBS="$SERVICE_LIBS $CUPS_LIBS"
14
15+SYSTEMD_USERDIR=`$PKG_CONFIG --variable=systemduserunitdir systemd`
16+AC_SUBST(SYSTEMD_USERDIR)
17
18 with_localinstall="no"
19 AC_ARG_ENABLE(localinstall, AS_HELP_STRING([--enable-localinstall],
20
21=== modified file 'data/Makefile.am'
22--- data/Makefile.am 2014-02-20 16:08:19 +0000
23+++ data/Makefile.am 2016-10-26 14:48:15 +0000
24@@ -6,6 +6,27 @@
25 SUBDIRS = upstart
26
27 #
28+# the systemd unit file
29+#
30+
31+systemddir = $(SYSTEMD_USERDIR)
32+systemd_DATA = indicator-printers.service
33+systemd_in = $(systemd_DATA:.service=.service.in)
34+$(systemd_DATA): $(systemd_in)
35+ $(AM_V_GEN) $(SED) -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
36+BUILT_SOURCES += $(systemd_DATA)
37+EXTRA_DIST += $(systemd_in)
38+CLEANFILES += $(systemd_DATA)
39+
40+#
41+# the systemd upstart override
42+#
43+
44+upstart_overridedir = $(datadir)/upstart/systemd-session/upstart
45+upstart_override_DATA = indicator-printers.override
46+EXTRA_DIST += $(upstart_override_DATA)
47+
48+#
49 # the upstart job file
50 #
51
52
53=== added file 'data/indicator-printers.override'
54--- data/indicator-printers.override 1970-01-01 00:00:00 +0000
55+++ data/indicator-printers.override 2016-10-26 14:48:15 +0000
56@@ -0,0 +1,1 @@
57+manual
58
59=== added file 'data/indicator-printers.service.in'
60--- data/indicator-printers.service.in 1970-01-01 00:00:00 +0000
61+++ data/indicator-printers.service.in 2016-10-26 14:48:15 +0000
62@@ -0,0 +1,8 @@
63+[Unit]
64+Description=Indicator Printers Service
65+PartOf=graphical-session.target
66+After=indicators-pre.target
67+
68+[Service]
69+ExecStart=@pkglibexecdir@/indicator-printers-service
70+Restart=on-failure
71
72=== modified file 'debian/control'
73--- debian/control 2015-02-06 16:33:33 +0000
74+++ debian/control 2016-10-26 14:48:15 +0000
75@@ -14,6 +14,7 @@
76 libdbusmenu-gtk3-dev (>= 0.5.90),
77 libindicator3-dev (>= 0.3.91),
78 libcups2-dev,
79+ systemd,
80 Standards-Version: 3.9.2
81 Homepage: https://launchpad.net/indicator-printers
82 # If you aren't a member of ~indicator-applet-developers but need to upload
83@@ -27,6 +28,7 @@
84 Depends: ${shlibs:Depends},
85 ${misc:Depends},
86 cups (>= 1.5),
87+ indicator-common,
88 Recommends: indicator-applet (>= 0.2) | indicator-renderer,
89 system-config-printer-gnome,
90 Description: indicator showing active print jobs

Subscribers

People subscribed via source and target branches