Merge lp:~ted/indicator-power/upstart-job into lp:indicator-power/13.10

Proposed by Ted Gould
Status: Superseded
Proposed branch: lp:~ted/indicator-power/upstart-job
Merge into: lp:indicator-power/13.10
Diff against target: 130 lines (+64/-14)
7 files modified
data/Makefile.am (+24/-11)
data/com.canonical.indicator.power (+3/-0)
data/indicator-power.conf.in (+11/-0)
data/indicator-power.desktop.in (+9/-0)
data/indicator-power.service.in (+0/-3)
debian/changelog (+16/-0)
src/ib-brightness-control.c (+1/-0)
To merge this branch: bzr merge lp:~ted/indicator-power/upstart-job
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Indicator Applet Developers Pending
Review via email: mp+182445@code.launchpad.net

This proposal has been superseded by a proposal from 2013-10-29.

Commit message

Switching DBus service to an Upstart Job.

Description of the change

Switching DBus service to an Upstart Job.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~ted/indicator-power/upstart-job updated
192. By Ted Gould

Dropping debugging for system-wide support

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~ted/indicator-power/upstart-job updated
193. By Ted Gould

Updating to trunk

194. By Ted Gould

Add in the autostart config

Unmerged revisions

194. By Ted Gould

Add in the autostart config

193. By Ted Gould

Updating to trunk

192. By Ted Gould

Dropping debugging for system-wide support

191. By Ted Gould

Switching the dvus service to an upstart job

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/Makefile.am'
2--- data/Makefile.am 2013-07-04 20:14:54 +0000
3+++ data/Makefile.am 2013-10-29 16:30:39 +0000
4@@ -10,17 +10,30 @@
5 dist_indicators_DATA = com.canonical.indicator.power
6
7 #
8-# the dbus service file
9-#
10-
11-dbus_servicesdir = $(datadir)/dbus-1/services
12-dbus_services_DATA = indicator-power.service
13-dbus_services_in = $(dbus_services_DATA:.service=.service.in)
14-$(dbus_services_DATA): $(dbus_services_in)
15- $(AM_V_GEN) $(SED) -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
16-BUILT_SOURCES += $(dbus_services_DATA)
17-CLEANFILES += $(dbus_services_DATA)
18-EXTRA_DIST += $(dbus_services_in)
19+# the upstart job file
20+#
21+
22+upstart_jobsdir = $(datadir)/upstart/sessions
23+upstart_jobs_DATA = indicator-power.conf
24+upstart_jobs_in = $(upstart_jobs_DATA:.conf=.conf.in)
25+$(upstart_jobs_DATA): $(upstart_jobs_in)
26+ $(AM_V_GEN) $(SED) -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
27+BUILT_SOURCES += $(upstart_jobs_DATA)
28+CLEANFILES += $(upstart_jobs_DATA)
29+EXTRA_DIST += $(upstart_jobs_in)
30+
31+#
32+# the xdg autostart job file
33+#
34+
35+xdg_autostartdir = /etc/xdg/autostart
36+xdg_autostart_DATA = indicator-power.desktop
37+xdg_autostart_in = $(xdg_autostart_DATA:.desktop=.desktop.in)
38+$(xdg_autostart_DATA): $(xdg_autostart_in)
39+ $(AM_V_GEN) $(SED) -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
40+BUILT_SOURCES += $(xdg_autostart_DATA)
41+CLEANFILES += $(xdg_autostart_DATA)
42+EXTRA_DIST += $(xdg_autostart_in)
43
44 #
45 # the gettings
46
47=== modified file 'data/com.canonical.indicator.power'
48--- data/com.canonical.indicator.power 2013-07-24 05:10:17 +0000
49+++ data/com.canonical.indicator.power 2013-10-29 16:30:39 +0000
50@@ -11,3 +11,6 @@
51
52 [desktop_greeter]
53 ObjectPath=/com/canonical/indicator/power/desktop_greeter
54+
55+[phone_greeter]
56+ObjectPath=/com/canonical/indicator/power/desktop_greeter
57
58=== added file 'data/indicator-power.conf.in'
59--- data/indicator-power.conf.in 1970-01-01 00:00:00 +0000
60+++ data/indicator-power.conf.in 2013-10-29 16:30:39 +0000
61@@ -0,0 +1,11 @@
62+description "Indicator Power Backend"
63+
64+# Want to move to indicator-services-[start|end], but that's not all
65+# there yet. Use the signals that exist today for now.
66+
67+start on indicators-loaded or indicator-services-start
68+stop on desktop-end or indicator-services-end
69+
70+respawn
71+
72+exec @pkglibexecdir@/indicator-power-service
73
74=== added file 'data/indicator-power.desktop.in'
75--- data/indicator-power.desktop.in 1970-01-01 00:00:00 +0000
76+++ data/indicator-power.desktop.in 2013-10-29 16:30:39 +0000
77@@ -0,0 +1,9 @@
78+[Desktop Entry]
79+Type=Application
80+Name=Indicator Power
81+Exec=@pkglibexecdir@/indicator-power-service
82+NotShowIn=Unity;
83+NoDisplay=true
84+StartupNotify=false
85+Terminal=false
86+
87
88=== removed file 'data/indicator-power.service.in'
89--- data/indicator-power.service.in 2013-07-04 20:14:54 +0000
90+++ data/indicator-power.service.in 1970-01-01 00:00:00 +0000
91@@ -1,3 +0,0 @@
92-[D-BUS Service]
93-Name=com.canonical.indicator.power
94-Exec=@pkglibexecdir@/indicator-power-service
95
96=== modified file 'debian/changelog'
97--- debian/changelog 2013-10-08 02:34:02 +0000
98+++ debian/changelog 2013-10-29 16:30:39 +0000
99@@ -1,3 +1,19 @@
100+indicator-power (12.10.6+14.04.20131029.1-0ubuntu1) trusty; urgency=low
101+
102+ [ Sebastien Bacher ]
103+ * Don't leak the g_file_get_contents value, reported by valgrind .
104+
105+ [ Marcus Tomlinson ]
106+ * Added torch icons to either end of brightness slider. (LP: #1227250)
107+
108+ [ Ted Gould ]
109+ * Adding a phone_greeter profile.
110+
111+ [ Ubuntu daily release ]
112+ * Automatic snapshot from revision 210
113+
114+ -- Ubuntu daily release <ps-jenkins@lists.canonical.com> Tue, 29 Oct 2013 10:31:03 +0000
115+
116 indicator-power (12.10.6+13.10.20131008-0ubuntu1) saucy; urgency=low
117
118 [ Ted Gould ]
119
120=== modified file 'src/ib-brightness-control.c'
121--- src/ib-brightness-control.c 2013-10-01 18:50:10 +0000
122+++ src/ib-brightness-control.c 2013-10-29 16:30:39 +0000
123@@ -126,6 +126,7 @@
124 g_error_free (error);
125 } else {
126 value = atoi (svalue);
127+ g_free (svalue);
128 }
129
130 g_free (filename);

Subscribers

People subscribed via source and target branches