Merge lp:~ted/indicator-messages/upstart-job into lp:~indicator-applet-developers/indicator-messages/trunk.13.10

Proposed by Ted Gould
Status: Work in progress
Proposed branch: lp:~ted/indicator-messages/upstart-job
Merge into: lp:~indicator-applet-developers/indicator-messages/trunk.13.10
Prerequisite: lp:~indicator-applet-developers/indicator-messages/consolidate
Diff against target: 115 lines (+25/-17)
9 files modified
data/Makefile.am (+6/-6)
data/indicator-messages.conf.in (+11/-0)
data/indicator-messages.service.in (+0/-3)
debian/gir1.2-messagingmenu-1.0.install (+1/-1)
debian/indicator-messages.install (+2/-2)
debian/libmessaging-menu-dev.install (+2/-2)
debian/libmessaging-menu0.install (+1/-1)
debian/rules (+1/-1)
src/Makefile.am (+1/-1)
To merge this branch: bzr merge lp:~ted/indicator-messages/upstart-job
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ken VanDine Pending
Review via email: mp+181188@code.launchpad.net

Commit message

Add Upstart job configuration

Description of the change

Well, the goal of this was to just switch to Upstart, but then I fixed the pkglibexec thing while I was there, and then did a multi-arch conversion. Somewhere it had to stop.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
359. By Ted Gould

Dropping debugging for system-wide support

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

359. By Ted Gould

Dropping debugging for system-wide support

358. By Ted Gould

Not sure how the dbus dir trickled in

357. By Ted Gould

Refixing the service binary

356. By Ted Gould

Merge in consolidate branch

355. By Ted Gould

Make everything work with pkglibexec and install the right files

354. By Ted Gould

Drop the D-Bus service directory

353. By Ted Gould

Switching to pkglibexec dir

352. By Ted Gould

Switching to an upstart job

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/Makefile.am'
2--- data/Makefile.am 2013-08-20 10:38:10 +0000
3+++ data/Makefile.am 2013-08-27 20:14:48 +0000
4@@ -1,10 +1,10 @@
5 SUBDIRS = icons
6
7-dbus_servicesdir = $(datadir)/dbus-1/services
8-dbus_services_DATA = indicator-messages.service
9+upstart_jobsdir = $(datadir)/upstart/sessions
10+upstart_jobs_DATA = indicator-messages.conf
11
12-%.service: %.service.in
13- sed -e "s|\@libexecdir\@|$(libexecdir)|" $< > $@
14+%.conf: %.conf.in
15+ sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
16
17 gsettings_SCHEMAS = com.canonical.indicator.messages.gschema.xml
18 @GSETTINGS_RULES@
19@@ -14,6 +14,6 @@
20
21 EXTRA_DIST = \
22 $(gsettings_SCHEMAS) \
23- indicator-messages.service.in
24+ indicator-messages.conf.in
25
26-CLEANFILES = indicator-messages.service
27+CLEANFILES = indicator-messages.conf
28
29=== added file 'data/indicator-messages.conf.in'
30--- data/indicator-messages.conf.in 1970-01-01 00:00:00 +0000
31+++ data/indicator-messages.conf.in 2013-08-27 20:14:48 +0000
32@@ -0,0 +1,11 @@
33+description "Indicator Messages Backend"
34+
35+# Want to move to indicator-services-[start|end], but that's not all
36+# there yet. Use the signals that exist today for now.
37+
38+start on indicators-loaded or indicator-services-start
39+stop on desktop-end or indicator-services-end
40+
41+respawn
42+
43+exec @pkglibexecdir@/indicator-messages-service
44
45=== removed file 'data/indicator-messages.service.in'
46--- data/indicator-messages.service.in 2011-01-27 23:00:31 +0000
47+++ data/indicator-messages.service.in 1970-01-01 00:00:00 +0000
48@@ -1,3 +0,0 @@
49-[D-BUS Service]
50-Name=com.canonical.indicator.messages
51-Exec=@libexecdir@/indicator-messages-service
52
53=== modified file 'debian/gir1.2-messagingmenu-1.0.install'
54--- debian/gir1.2-messagingmenu-1.0.install 2012-08-23 11:28:52 +0000
55+++ debian/gir1.2-messagingmenu-1.0.install 2013-08-27 20:14:48 +0000
56@@ -1,1 +1,1 @@
57-usr/lib/girepository-1.0/*.typelib
58+usr/lib/*/girepository-1.0/*.typelib /usr/lib/girepository-1.0/
59
60=== modified file 'debian/indicator-messages.install'
61--- debian/indicator-messages.install 2013-08-20 10:38:10 +0000
62+++ debian/indicator-messages.install 2013-08-27 20:14:48 +0000
63@@ -1,5 +1,5 @@
64-usr/lib/indicator-messages/indicator-messages-service
65-usr/share/dbus-1
66+usr/lib/*/indicator-messages/indicator-messages-service
67+usr/share/upstart
68 usr/share/glib-2.0
69 usr/share/icons
70 usr/share/unity/indicators
71
72=== modified file 'debian/libmessaging-menu-dev.install'
73--- debian/libmessaging-menu-dev.install 2013-08-20 10:38:10 +0000
74+++ debian/libmessaging-menu-dev.install 2013-08-27 20:14:48 +0000
75@@ -1,5 +1,5 @@
76-usr/lib/libmessaging-menu.so
77-usr/lib/pkgconfig
78+usr/lib/*/libmessaging-menu.so
79+usr/lib/*/pkgconfig
80 usr/include /usr/
81 usr/share/gir-1.0/
82 usr/share/vala/
83
84=== modified file 'debian/libmessaging-menu0.install'
85--- debian/libmessaging-menu0.install 2012-08-23 11:28:52 +0000
86+++ debian/libmessaging-menu0.install 2013-08-27 20:14:48 +0000
87@@ -1,1 +1,1 @@
88-usr/lib/libmessaging-menu.so.* /usr/lib/
89+usr/lib/*/libmessaging-menu.so.*
90
91=== modified file 'debian/rules'
92--- debian/rules 2012-11-13 18:45:32 +0000
93+++ debian/rules 2013-08-27 20:14:48 +0000
94@@ -9,7 +9,7 @@
95 NO_CONFIGURE=1 dh_autoreconf ./autogen.sh
96
97 override_dh_auto_configure:
98- dh_auto_configure -- --libdir="\$${prefix}/lib" --libexecdir="\$${prefix}/lib/indicator-messages" --enable-gtk-doc
99+ dh_auto_configure -- --enable-gtk-doc
100
101 override_dh_install:
102 find debian/tmp/usr/lib -name *.la -delete
103
104=== modified file 'src/Makefile.am'
105--- src/Makefile.am 2013-08-22 12:44:10 +0000
106+++ src/Makefile.am 2013-08-27 20:14:48 +0000
107@@ -1,7 +1,7 @@
108
109 EXTRA_DIST =
110
111-libexec_PROGRAMS = indicator-messages-service
112+pkglibexec_PROGRAMS = indicator-messages-service
113
114 indicator_messages_service_SOURCES = \
115 messages-service.c \

Subscribers

People subscribed via source and target branches