Merge lp:~ted/indicator-messages/startup-cleanup into lp:indicator-messages/14.04

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 409
Merged at revision: 407
Proposed branch: lp:~ted/indicator-messages/startup-cleanup
Merge into: lp:indicator-messages/14.04
Diff against target: 132 lines (+60/-14)
8 files modified
configure.ac (+1/-0)
data/Makefile.am (+19/-10)
data/indicator-messages.conf.in (+10/-0)
data/indicator-messages.desktop.in (+8/-0)
data/indicator-messages.service.in (+0/-3)
data/upstart/Makefile.am (+12/-0)
data/upstart/indicator-messages.desktop.in (+8/-0)
debian/indicator-messages.install (+2/-1)
To merge this branch: bzr merge lp:~ted/indicator-messages/startup-cleanup
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+207775@code.launchpad.net

Commit message

Synchronize process management across indicators

Description of the change

This merge goes along with all of the other "startup-cleanup" merges to create a consistent startup for all indicators.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

I built debs for all the startup-cleanup branches and tested them out; WfM

review: Approve
410. By Ted Gould

Update for gnome-fallback

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2013-08-27 02:46:33 +0000
3+++ configure.ac 2014-02-26 16:37:52 +0000
4@@ -169,6 +169,7 @@
5 data/icons/scalable/Makefile
6 data/icons/scalable/status/Makefile
7 data/icons/scalable/categories/Makefile
8+data/upstart/Makefile
9 po/Makefile.in
10 test/Makefile
11 libmessaging-menu/Makefile
12
13=== modified file 'data/Makefile.am'
14--- data/Makefile.am 2013-09-06 10:54:47 +0000
15+++ data/Makefile.am 2014-02-26 16:37:52 +0000
16@@ -1,10 +1,16 @@
17-SUBDIRS = icons
18-
19-dbus_servicesdir = $(datadir)/dbus-1/services
20-dbus_services_DATA = indicator-messages.service
21-
22-%.service: %.service.in
23- sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
24+SUBDIRS = icons upstart
25+
26+xdg_autostartdir = /etc/xdg/autostart
27+xdg_autostart_DATA = indicator-messages.desktop
28+
29+%.desktop: %.desktop.in
30+ $(AM_V_GEN) sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
31+
32+upstart_jobsdir = $(datadir)/upstart/sessions/
33+upstart_jobs_DATA = indicator-messages.conf
34+
35+%.conf: %.conf.in
36+ $(AM_V_GEN) sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
37
38 gsettings_SCHEMAS = com.canonical.indicator.messages.gschema.xml
39 @GSETTINGS_RULES@
40@@ -13,7 +19,10 @@
41 dist_indicator_DATA = com.canonical.indicator.messages
42
43 EXTRA_DIST = \
44- $(gsettings_SCHEMAS) \
45- indicator-messages.service.in
46+ indicator-messages.desktop.in \
47+ indicator-messages.conf.in \
48+ $(gsettings_SCHEMAS)
49
50-CLEANFILES = indicator-messages.service
51+CLEANFILES = \
52+ $(xdg_autostart_DATA) \
53+ $(upstart_jobs_DATA)
54
55=== added file 'data/indicator-messages.conf.in'
56--- data/indicator-messages.conf.in 1970-01-01 00:00:00 +0000
57+++ data/indicator-messages.conf.in 2014-02-26 16:37:52 +0000
58@@ -0,0 +1,10 @@
59+description "Indicator Messages Service"
60+
61+start on indicator-services-start
62+stop on desktop-end or indicator-services-end
63+
64+respawn
65+respawn limit 2 10
66+
67+exec @pkglibexecdir@/indicator-messages-service
68+
69
70=== added file 'data/indicator-messages.desktop.in'
71--- data/indicator-messages.desktop.in 1970-01-01 00:00:00 +0000
72+++ data/indicator-messages.desktop.in 2014-02-26 16:37:52 +0000
73@@ -0,0 +1,8 @@
74+[Desktop Entry]
75+Type=Application
76+Name=Indicator Messages
77+Exec=@pkglibexecdir@/indicator-messages-service
78+StartupNotify=false
79+Terminal=false
80+OnlyShowIn=Unity;GNOME;
81+AutostartCondition=GNOME3 unless-session gnome
82
83=== removed file 'data/indicator-messages.service.in'
84--- data/indicator-messages.service.in 2013-09-06 10:54:47 +0000
85+++ data/indicator-messages.service.in 1970-01-01 00:00:00 +0000
86@@ -1,3 +0,0 @@
87-[D-BUS Service]
88-Name=com.canonical.indicator.messages
89-Exec=@pkglibexecdir@/indicator-messages-service
90
91=== added directory 'data/upstart'
92=== added file 'data/upstart/Makefile.am'
93--- data/upstart/Makefile.am 1970-01-01 00:00:00 +0000
94+++ data/upstart/Makefile.am 2014-02-26 16:37:52 +0000
95@@ -0,0 +1,12 @@
96+
97+xdg_autostartdir = $(datadir)/upstart/xdg/autostart
98+xdg_autostart_DATA = indicator-messages.desktop
99+
100+%.desktop: %.desktop.in
101+ $(AM_V_GEN) sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
102+
103+EXTRA_DIST = \
104+ indicator-messages.desktop.in
105+
106+CLEANFILES = \
107+ $(xdg_autostart_DATA)
108
109=== added file 'data/upstart/indicator-messages.desktop.in'
110--- data/upstart/indicator-messages.desktop.in 1970-01-01 00:00:00 +0000
111+++ data/upstart/indicator-messages.desktop.in 2014-02-26 16:37:52 +0000
112@@ -0,0 +1,8 @@
113+[Desktop Entry]
114+Type=Application
115+Name=Indicator Messages
116+Exec=@pkglibexecdir@/indicator-messages-service
117+StartupNotify=false
118+Terminal=false
119+OnlyShowIn=Unity;
120+Hidden=true
121
122=== modified file 'debian/indicator-messages.install'
123--- debian/indicator-messages.install 2013-09-06 12:00:13 +0000
124+++ debian/indicator-messages.install 2014-02-26 16:37:52 +0000
125@@ -1,5 +1,6 @@
126 usr/lib/*/indicator-messages/indicator-messages-service
127-usr/share/dbus-1
128+usr/share/upstart
129 usr/share/glib-2.0
130 usr/share/icons
131 usr/share/unity/indicators
132+etc/xdg/autostart

Subscribers

People subscribed via source and target branches