Merge lp:~ted/indicator-keyboard/merge-policy into lp:indicator-keyboard

Proposed by Ted Gould
Status: Merged
Approved by: Charles Kerr
Approved revision: 224
Merged at revision: 255
Proposed branch: lp:~ted/indicator-keyboard/merge-policy
Merge into: lp:indicator-keyboard
Diff against target: 52 lines (+43/-0)
2 files modified
MERGE-REVIEW (+19/-0)
tests/manual (+24/-0)
To merge this branch: bzr merge lp:~ted/indicator-keyboard/merge-policy
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Charles Kerr (community) Approve
Review via email: mp+204339@code.launchpad.net

Commit message

Adding acceptance tests and merge review policies

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'MERGE-REVIEW'
2--- MERGE-REVIEW 1970-01-01 00:00:00 +0000
3+++ MERGE-REVIEW 2014-01-31 20:21:07 +0000
4@@ -0,0 +1,19 @@
5+
6+This documents the expections that the project has on what both submitters
7+and reviewers should ensure that they've done for a merge into the project.
8+
9+== Submitter Responsibilities ==
10+
11+ * Ensure the project compiles and the test suite executes without error
12+ * Ensure that non-obvious code has comments explaining it
13+ * If the change works on specific profiles, please include those in the merge description.
14+
15+== Reviewer Responsibilities ==
16+
17+ * Did the Jenkins build compile? Pass? Run unit tests successfully?
18+ * Are there appropriate tests to cover any new functionality?
19+ * If the description says this effects the phone profile:
20+ * Run tests indicator-keyboard/unity8*
21+ * If the description says this effects the desktop profile:
22+ * Run tests indicator-keyboard/unity7*
23+
24
25=== added file 'tests/manual'
26--- tests/manual 1970-01-01 00:00:00 +0000
27+++ tests/manual 2014-01-31 20:21:07 +0000
28@@ -0,0 +1,24 @@
29+
30+Test-case indicator-keyboard/unity7-items-check
31+<dl>
32+ <dt>Log in to a Unity 7 user session</dt>
33+ <dt>Go to the panel and click on the Keyboard indicator</dt>
34+ <dd>Ensure there are items in the menu</dd>
35+</dl>
36+
37+Test-case indicator-keyboard/unity7-greeter-items-check
38+<dl>
39+ <dt>Start a system and wait for the greeter or logout of the current user session</dt>
40+ <dt>Go to the panel and click on the Keyboard indicator</dt>
41+ <dd>Ensure there are items in the menu</dd>
42+</dl>
43+
44+Test-case indicator-keyboard/unity8-items-check
45+<dl>
46+ <dt>Login to a user session running Unity 8</dt>
47+ <dt>Pull down the top panel until it sticks open</dt>
48+ <dt>Navigate through the tabs until "Keyboard" is shown</dt>
49+ <dd>Keyboard is at the top of the menu</dd>
50+ <dd>The menu is populated with items</dd>
51+</dl>
52+

Subscribers

People subscribed via source and target branches

to all changes: