Merge lp:~ted/indicator-display/fix-cppcheck into lp:indicator-display

[Ted Gould]

Make the public_key parameter a reference

cppcheck on yakkety is unhappy

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:20
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-display-ci/3/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/669/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/675
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/490
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=vivid+overlay/490/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/490
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/490/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/490
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=yakkety/490/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/490
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=vivid+overlay/490/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/490
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/490/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/490
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=yakkety/490/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=vivid+overlay/490/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/490
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/490/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/490
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=yakkety/490/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-display-ci/3/rebuild

review: Needs Fixing (continuous-integration)

[Charles Kerr (charlesk)]

review: Approve

Unmerged revisions

20. By Ted Gould on 2016-09-15

Make the string parameter a reference

=== modified file 'src/adbd-client.cpp'
--- src/adbd-client.cpp	2016-03-24 16:01:16 +0000
+++ src/adbd-client.cpp	2016-09-15 19:07:00 +0000
@@ -66,7 +66,7 @@
         GCancellable* cancellable = nullptr;
         const std::string public_key;
 
-        PKIdleData(Impl* self_, GCancellable* cancellable_, std::string public_key_):
+        PKIdleData(Impl* self_, GCancellable* cancellable_, const std::string& public_key_):
             self(self_),
             cancellable(G_CANCELLABLE(g_object_ref(cancellable_))),
             public_key(public_key_) {}