Merge lp:~ted/indicator-datetime/no-crash-geoclue into lp:indicator-datetime/0.3
Proposed by
Ted Gould
Status: | Merged |
---|---|
Merged at revision: | 37 |
Proposed branch: | lp:~ted/indicator-datetime/no-crash-geoclue |
Merge into: | lp:indicator-datetime/0.3 |
Diff against target: |
39 lines (+15/-0) 1 file modified
src/datetime-service.c (+15/-0) |
To merge this branch: | bzr merge lp:~ted/indicator-datetime/no-crash-geoclue |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mikkel Kamstrup Erlandsen (community) | Approve | ||
Review via email: mp+48105@code.launchpad.net |
Description of the change
Well, there's a case where it seems people's datetime will crash if they don't have ubuntu-geoip installed. And I thought I could recreate it. But, I've been unable though I reviewed the GeoClue code and here are some additional safe gaurds that could be added to hopefully stop the crash.
To post a comment you must log in.
It's unclear to me exactly what situation these checks guard against. Can you add a code comment explaining the situation before you merge this?