Code review comment for lp:~ted/indicator-appmenu/hud

Revision history for this message
Ted Gould (ted) wrote :

> * indicator-sound recently changed signature from
> "com.canonical.indicators.sound" (note the plural) to
> "com.canonical.indicator.sound" (note the singular) to follow the
> other indicators' conventions. You may want to use the new signature?

Added both, will delete as indicator-sound gets shipped wider. r197

> * struct _AppIndicator's fields "alert", "alert_name", and
> "normal_name" appear to be unused.

Future use :-)

> * I agree with awe that having a "return;" alone at the end of a void
> function is kind of weird ;)

I think not having it is weird :-)

« Back to merge proposal