Code review comment for lp:~ted/indicator-appmenu/hud

Revision history for this message
Tony Espy (awe) wrote :

> > * larsu points out that only <glib.h> is required, not an
> > additional include for <glib-object.h>; I looked at this, and can't
> > quite grok how this chaining works as <glib.h> doesn't appear to
> > pull in any of the GObject headers?
>
> Sorry if I wasn't clear: glib-object.h includes glib.h, not the other
> way around. (glib itself doesn't depend on gobject)

Ah, I didn't think to look at the reverse! Thanks for the clarification!

> > [...] * Regarding line length... the vt130 comment was funny, but
> > not a real justification. I would suggest checking out a few public
> > C/C++ styleguides ( GTK+, Google Style Guides, ... ) for reference,
> > most if not all recommend 80 char lines.
>
> In general, I totally agree with a 80 char limit. However, the g*
> libraries have an affinity towards fairly long function names, which
> can make this hard to enforce sometimes.

Well, I'm certainly up for setting the length longer ( 100? 120? ), as
long as there's an agreed upon convention we all can abide by...

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQEcBAEBAgAGBQJPIrXeAAoJEAbD1bcyW6kFyu8H/0wxSAHY4iEwIRUzhEkvFzFV
> f/dkNSdWR9ODyOruDmGs3QIldW1iV3B2rTv4ZxXt3RECVUTsme0tCR7Gea+oU81H
> 8lQKV0tP2E81g6H5QqOP4o/tDbw3OaFoBIYfDNdCejaRjM1c6fip8kOmtcfl2gdR
> PoonUiw8D9BT6gFqo3dFsy+KNmEg1rHRwvjq9GVrkfJXywCylIkz63FIoHQijR7s
> nr7hkO/6CG5jAEU9FDcKgTg+KK622WqVWCy7Bupp24LVEtdyuJO3wuYseH2Xe9Kf
> WI0pUAODJh3CAp/dydkMHWiVR0L+jXKuKzmoCio8p4L0/Q//GwSuvILISnxysLU=
> =de0l
> -----END PGP SIGNATURE-----

« Back to merge proposal