Merge lp:~ted/indicator-appmenu/desc-reference into lp:indicator-appmenu/12.10
Proposed by
Ted Gould
Status: | Merged |
---|---|
Approved by: | Charles Kerr |
Approved revision: | 211 |
Merge reported by: | Lars Karlitski |
Merged at revision: | not available |
Proposed branch: | lp:~ted/indicator-appmenu/desc-reference |
Merge into: | lp:indicator-appmenu/12.10 |
Diff against target: |
42 lines (+10/-1) 1 file modified
src/window-menu-dbusmenu.c (+10/-1) |
To merge this branch: | bzr merge lp:~ted/indicator-appmenu/desc-reference |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Kerr (community) | Approve | ||
Review via email: mp+127056@code.launchpad.net |
Commit message
Reference the variant used for the accessible description
Description of the change
There is a tricky race condition here where the label can be changed, but the signal to say so hasn't been notified. Basically this comes up when multiple properties are change, someone responds to them, and requires the accessible description before it knows that it's changed and the pointer has been updated. So, to ensure that the pointer remains valid we reference the variant that contians it, and then update as it changes.
To post a comment you must log in.
Ted, how'd you find this one? :)