Application Menu Indicator

Merge lp:~ted/indicator-appmenu/alt-d-problem into lp:indicator-appmenu/0.3

  1. alt-d-problem
  2. Merge into trunk
Proposed by Ted Gould on 2010-12-03
Status: Merged
Merged at revision: 83
Proposed branch: lp:~ted/indicator-appmenu/alt-d-problem
Merge into: lp:indicator-appmenu/0.3
Diff against target: 12 lines (+1/-1)
1 file modified
src/window-menus.c (+1/-1)
To merge this branch: bzr merge lp:~ted/indicator-appmenu/alt-d-problem
Reviewer Review Type Date Requested Status
Cody Russell (community) 2010-12-03 Approve on 2010-12-03
Review via email: mp+42699@code.launchpad.net

Description of the Change

Switching the call order to get_position so we check the right child against the right parent.

To post a comment you must log in.
Cody Russell (bratsche) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/window-menus.c'
2--- src/window-menus.c 2010-09-21 21:38:18 +0000
3+++ src/window-menus.c 2010-12-03 22:56:58 +0000
4@@ -317,7 +317,7 @@
5 return;
6 }
7
8- guint position = dbusmenu_menuitem_get_position(priv->root, item);
9+ guint position = dbusmenu_menuitem_get_position(item, priv->root);
10 if (position == 0) {
11 /* Ugly, ugly hack. I shouldn't have used guint in the function
12 above, but now I have to do this. Ew! */

Subscribers

People subscribed via source and target branches