Merge lp:~ted/indicator-application/bug640838 into lp:indicator-application/0.2

Proposed by Ted Gould
Status: Merged
Merged at revision: 167
Proposed branch: lp:~ted/indicator-application/bug640838
Merge into: lp:indicator-application/0.2
Diff against target: 11 lines (+1/-0)
1 file modified
src/application-service-appstore.c (+1/-0)
To merge this branch: bzr merge lp:~ted/indicator-application/bug640838
Reviewer Review Type Date Requested Status
Jay Taoko (community) Approve
Review via email: mp+47626@code.launchpad.net

This proposal supersedes a proposal from 2011-01-19.

Description of the change

Removes the signal handler before unreffing the proxy. Think that's the problem in bug 640838.

To post a comment you must log in.
Revision history for this message
Jay Taoko (jaytaoko) wrote :

Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/application-service-appstore.c'
2--- src/application-service-appstore.c 2010-10-08 15:02:24 +0000
3+++ src/application-service-appstore.c 2011-01-27 02:23:10 +0000
4@@ -1141,6 +1141,7 @@
5
6 if (approver->proxy != NULL) {
7 if (!approver->destroy_by_proxy) {
8+ g_signal_handler_disconnect_by_func(G_OBJECT(approver->proxy), G_CALLBACK(approver_destroyed), appstore);
9 g_object_unref(approver->proxy);
10 }
11 approver->proxy = NULL;

Subscribers

People subscribed via source and target branches