Merge lp:~ted/indicator-application/attention-icon into lp:indicator-application/0.4

Proposed by Ted Gould
Status: Merged
Merged at revision: 159
Proposed branch: lp:~ted/indicator-application/attention-icon
Merge into: lp:indicator-application/0.4
Diff against target: 18 lines (+8/-1)
1 file modified
src/application-service-appstore.c (+8/-1)
To merge this branch: bzr merge lp:~ted/indicator-application/attention-icon
Reviewer Review Type Date Requested Status
Aurélien Gâteau (community) Approve
Cody Russell (community) Approve
Review via email: mp+35552@code.launchpad.net

Description of the change

Small fix to the attention icons by making it so that we always update the icon. Not perfect, but very harmless.

To post a comment you must log in.
Revision history for this message
Cody Russell (bratsche) :
review: Approve
Revision history for this message
Aurélien Gâteau (agateau) wrote :

Tested with Konversation: icon now turns red, as expected. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/application-service-appstore.c'
2--- src/application-service-appstore.c 2010-09-08 00:22:05 +0000
3+++ src/application-service-appstore.c 2010-09-15 16:20:59 +0000
4@@ -602,7 +602,14 @@
5 }
6
7 /* Nothing needs to change, we're good */
8- if (app->visible_state == goal_state) {
9+ if (app->visible_state == goal_state /* ) { */
10+ && goal_state == VISIBLE_STATE_HIDDEN) {
11+ /* TODO: Uhg, this is a little wrong in that we're going to
12+ send an icon every time the status changes and the indicator
13+ is visible even though it might not be updating. But, at
14+ this point we need a small patch that is harmless. In the
15+ future we need to track which icon is shown and remove the
16+ duplicate message. */
17 return;
18 }
19

Subscribers

People subscribed via source and target branches