Merge lp:~ted/indicator-applet/window-menus into lp:indicator-applet/0.4

Proposed by Ted Gould
Status: Merged
Merged at revision: not available
Proposed branch: lp:~ted/indicator-applet/window-menus
Merge into: lp:indicator-applet/0.4
Diff against target: 215 lines (+94/-7)
7 files modified
.bzrignore (+4/-0)
data/GNOME_IndicatorAppletAppmenu.server.in.in (+28/-0)
data/Makefile.am (+2/-3)
po/POTFILES.in (+4/-3)
po/POTFILES.skip (+5/-1)
src/Makefile.am (+20/-0)
src/applet-main.c (+31/-0)
To merge this branch: bzr merge lp:~ted/indicator-applet/window-menus
Reviewer Review Type Date Requested Status
Conor Curran (community) Approve
Review via email: mp+24504@code.launchpad.net

Description of the change

Adds a new build target for the appmenu indicator.

To post a comment you must log in.
Revision history for this message
Conor Curran (cjcurran) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2010-04-16 18:59:21 +0000
3+++ .bzrignore 2010-04-30 15:05:27 +0000
4@@ -137,3 +137,7 @@
5 po/stamp-it
6 src/Makefile
7 src/Makefile.in
8+data/GNOME_IndicatorAppletAppmenu.server
9+data/GNOME_IndicatorAppletAppmenu.server.in
10+src/indicator-applet-appmenu
11+data/GNOME_IndicatorAppletComplete.server.in
12
13=== added file 'data/GNOME_IndicatorAppletAppmenu.server.in.in'
14--- data/GNOME_IndicatorAppletAppmenu.server.in.in 1970-01-01 00:00:00 +0000
15+++ data/GNOME_IndicatorAppletAppmenu.server.in.in 2010-04-30 15:05:27 +0000
16@@ -0,0 +1,28 @@
17+<oaf_info>
18+ <oaf_server iid="OAFIID:GNOME_IndicatorAppletAppmenu_Factory" type="exe"
19+ location="@LIBEXECDIR@/indicator-applet-appmenu">
20+
21+ <oaf_attribute name="repo_ids" type="stringv">
22+ <item value="IDL:Bonobo/GenericFactory:1.0"/>
23+ <item value="IDL:Bonobo/Unknown:1.0"/>
24+ </oaf_attribute>
25+ <oaf_attribute name="name" type="string" value="Indicator Applet Appmenu Factory"/>
26+ <oaf_attribute name="description" type="string" value="Indicator Applet Appmenu Factory"/>
27+ <oaf_attribute name="bonobo:environment" type="stringv">
28+ <item value="DBUS_SESSION_BUS_ADDRESS"/>
29+ </oaf_attribute>
30+ </oaf_server>
31+
32+ <oaf_server iid="OAFIID:GNOME_IndicatorAppletAppmenu" type="factory"
33+ location="OAFIID:GNOME_IndicatorAppletAppmenu_Factory">
34+
35+ <oaf_attribute name="repo_ids" type="stringv">
36+ <item value="IDL:GNOME/Vertigo/PanelAppletShell:1.0"/>
37+ <item value="IDL:Bonobo/Control:1.0"/>
38+ <item value="IDL:Bonobo/Unknown:1.0"/>
39+ </oaf_attribute>
40+ <oaf_attribute name="name" type="string" _value="Indicator Applet Appmenu"/>
41+ <oaf_attribute name="description" type="string" _value="A applet containing the application menus."/>
42+ <oaf_attribute name="panel:icon" type="string" value="indicator-applet"/>
43+ </oaf_server>
44+</oaf_info>
45
46=== modified file 'data/Makefile.am'
47--- data/Makefile.am 2010-01-04 19:26:05 +0000
48+++ data/Makefile.am 2010-04-30 15:05:27 +0000
49@@ -9,6 +9,7 @@
50 server_in_files = \
51 GNOME_IndicatorApplet.server.in \
52 GNOME_IndicatorAppletComplete.server.in \
53+ GNOME_IndicatorAppletAppmenu.server.in \
54 GNOME_FastUserSwitchApplet.server.in
55 server_DATA = \
56 $(server_in_files:.server.in=.server)
57@@ -68,9 +69,7 @@
58
59 EXTRA_DIST = \
60 $(icons_DATA) \
61- GNOME_IndicatorApplet.server.in.in \
62- GNOME_IndicatorAppletComplete.server.in.in \
63- GNOME_FastUserSwitchApplet.server.in.in \
64+ $(server_in_files) \
65 $(schema_in_files)
66
67 MAINTAINERCLEANFILES = \
68
69=== modified file 'po/POTFILES.in'
70--- po/POTFILES.in 2010-01-04 19:34:23 +0000
71+++ po/POTFILES.in 2010-04-30 15:05:27 +0000
72@@ -1,6 +1,7 @@
73 [encoding: UTF-8]
74-data/GNOME_IndicatorApplet.server.in.in
75-data/GNOME_IndicatorAppletComplete.server.in.in
76-data/GNOME_FastUserSwitchApplet.server.in.in
77+data/GNOME_IndicatorApplet.server.in
78+data/GNOME_IndicatorAppletAppmenu.server.in
79+data/GNOME_IndicatorAppletComplete.server.in
80+data/GNOME_FastUserSwitchApplet.server.in
81 data/indicator-applet.schemas.in
82 src/applet-main.c
83
84=== modified file 'po/POTFILES.skip'
85--- po/POTFILES.skip 2008-10-30 17:31:31 +0000
86+++ po/POTFILES.skip 2010-04-30 15:05:27 +0000
87@@ -1,1 +1,5 @@
88-data/GNOME_IndicatorApplet.server.in
89+data/GNOME_FastUserSwitchApplet.server.in.in
90+data/GNOME_IndicatorApplet.server.in.in
91+data/GNOME_IndicatorAppletAppmenu.server.in.in
92+data/GNOME_IndicatorAppletComplete.server.in.in
93+
94
95=== modified file 'src/Makefile.am'
96--- src/Makefile.am 2010-03-02 22:24:00 +0000
97+++ src/Makefile.am 2010-04-30 15:05:27 +0000
98@@ -1,6 +1,7 @@
99
100 libexec_PROGRAMS = \
101 indicator-applet \
102+ indicator-applet-appmenu \
103 indicator-applet-session \
104 indicator-applet-complete
105
106@@ -23,6 +24,25 @@
107 indicator_applet_LDADD = \
108 $(APPLET_LIBS)
109
110+indicator_applet_appmenu_CFLAGS = \
111+ -DG_LOG_DOMAIN=\""Indicator-Applet-Appmenu"\" \
112+ -DDATADIR=\""$(datadir)"\" \
113+ -DINDICATOR_DIR=\""$(INDICATORDIR)"\" \
114+ -DINDICATOR_ICONS_DIR=\""$(INDICATORICONSDIR)"\" \
115+ -DINDICATOR_APPLET_APPMENU \
116+ -I$(srcdir)/.. \
117+ $(APPLET_CFLAGS)
118+
119+indicator_applet_appmenu_SOURCES = \
120+ applet-main.c \
121+ eggaccelerators.c \
122+ eggaccelerators.h \
123+ tomboykeybinder.c \
124+ tomboykeybinder.h
125+
126+indicator_applet_appmenu_LDADD = \
127+ $(APPLET_LIBS)
128+
129 indicator_applet_session_CFLAGS = \
130 -DG_LOG_DOMAIN=\""Indicator-Applet-Session"\" \
131 -DDATADIR=\""$(datadir)"\" \
132
133=== modified file 'src/applet-main.c'
134--- src/applet-main.c 2010-04-19 02:21:44 +0000
135+++ src/applet-main.c 2010-04-30 15:05:27 +0000
136@@ -76,6 +76,12 @@
137 "indicator-applet-complete", "0",
138 applet_fill_cb, NULL);
139 #endif
140+#ifdef INDICATOR_APPLET_APPMENU
141+PANEL_APPLET_BONOBO_FACTORY ("OAFIID:GNOME_IndicatorAppletAppmenu_Factory",
142+ PANEL_TYPE_APPLET,
143+ "indicator-applet-appmenu", "0",
144+ applet_fill_cb, NULL);
145+#endif
146
147 /*************
148 * log files
149@@ -89,6 +95,9 @@
150 #ifdef INDICATOR_APPLET_COMPLETE
151 #define LOG_FILE_NAME "indicator-applet-complete.log"
152 #endif
153+#ifdef INDICATOR_APPLET_APPMENU
154+#define LOG_FILE_NAME "indicator-applet-appmenu.log"
155+#endif
156 GOutputStream * log_file = NULL;
157
158 /*****************
159@@ -103,6 +112,9 @@
160 #ifdef INDICATOR_APPLET_COMPLETE
161 gchar * hotkey_keycode = "<Super>S";
162 #endif
163+#ifdef INDICATOR_APPLET_APPMENU
164+gchar * hotkey_keycode = "<Super>F1";
165+#endif
166
167 /*************
168 * init function
169@@ -443,6 +455,9 @@
170 #ifdef INDICATOR_APPLET_SESSION
171 "comments", _("A place to adjust your status, change users or exit your session."),
172 #else
173+#ifdef INDICATOR_APPLET_APPMENU
174+ "comments", _("An applet to hold your application menus."),
175+#endif
176 "comments", _("An applet to hold all of the system indicators."),
177 #endif
178 "authors", authors,
179@@ -625,6 +640,9 @@
180 #ifdef INDICATOR_APPLET_COMPLETE
181 g_set_application_name(_("Indicator Applet Complete"));
182 #endif
183+#ifdef INDICATOR_APPLET_APPMENU
184+ g_set_application_name(_("Indicator Applet Application Menu"));
185+#endif
186
187 g_log_set_default_handler(log_to_file, NULL);
188
189@@ -648,6 +666,10 @@
190 atk_object_set_name (gtk_widget_get_accessible (GTK_WIDGET (applet)),
191 "indicator-applet-complete");
192 #endif
193+#ifdef INDICATOR_APPLET_APPMENU
194+ atk_object_set_name (gtk_widget_get_accessible (GTK_WIDGET (applet)),
195+ "indicator-applet-appmenu");
196+#endif
197
198 /* Init some theme/icon stuff */
199 gtk_icon_theme_append_search_path(gtk_icon_theme_get_default(),
200@@ -706,6 +728,15 @@
201
202 const gchar * name;
203 while ((name = g_dir_read_name(dir)) != NULL) {
204+#ifdef INDICATOR_APPLET_APPMENU
205+ if (g_strcmp0(name, "libappmenu.so")) {
206+ continue;
207+ }
208+#else
209+ if (!g_strcmp0(name, "libappmenu.so")) {
210+ continue;
211+ }
212+#endif
213 #ifdef INDICATOR_APPLET
214 if (!g_strcmp0(name, "libsession.so")) {
215 continue;

Subscribers

People subscribed via source and target branches

to status/vote changes: