Merge lp:~ted/hud/disable-unused-tests into lp:hud/13.10

Proposed by Ted Gould
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 266
Merged at revision: 263
Proposed branch: lp:~ted/hud/disable-unused-tests
Merge into: lp:hud/13.10
Diff against target: 69 lines (+0/-28)
3 files modified
debian/control (+0/-6)
tests/CMakeLists.txt (+0/-1)
tests/test-dbus-message-count.in (+0/-21)
To merge this branch: bzr merge lp:~ted/hud/disable-unused-tests
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+167077@code.launchpad.net

Commit message

Remove unused test and cleanup dependencies

Description of the change

The dbus message count test is unused and adds a bunch of dependencies that makes HUD hard to build on the phone. Let's fix that.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
lp:~ted/hud/disable-unused-tests updated
265. By Ted Gould

Dbus test runner packaging still broken, someone should fix that.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:265
http://jenkins.qa.ubuntu.com/job/hud-ci/36/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-raring-amd64-ci/40
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-raring-i386-ci/25

Click here to trigger a rebuild:
http://s-jenkins:8080/job/hud-ci/36/rebuild

review: Approve (continuous-integration)
lp:~ted/hud/disable-unused-tests updated
266. By Ted Gould

Alphabetical order is hard

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:266
http://jenkins.qa.ubuntu.com/job/hud-ci/37/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-raring-amd64-ci/41
    SUCCESS: http://jenkins.qa.ubuntu.com/job/hud-raring-i386-ci/26

Click here to trigger a rebuild:
http://s-jenkins:8080/job/hud-ci/37/rebuild

review: Approve (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approve!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-05-21 01:03:09 +0000
3+++ debian/control 2013-06-03 16:41:27 +0000
4@@ -4,7 +4,6 @@
5 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
6 Build-Depends: bamfdaemon,
7 cmake,
8- bustle,
9 dbus-test-runner,
10 debhelper (>= 9),
11 dh-autoreconf,
12@@ -14,11 +13,7 @@
13 gobject-introspection,
14 gtester2xunit,
15 gtk-doc-tools,
16- indicator-application (>= 0.4.90),
17- indicator-appmenu,
18- indicator-appmenu-tools,
19 intltool,
20- libappindicator3-dev,
21 libbamf3-dev (>= 0.2.53) [!armhf],
22 libubuntu-platform-api1-dev [armhf],
23 libdbusmenu-glib-dev (>= 0.5.90),
24@@ -29,7 +24,6 @@
25 libgirepository1.0-dev,
26 libgtk-3-dev,
27 libsqlite3-dev,
28- metacity,
29 sqlite3,
30 valac-0.18,
31 xvfb,
32
33=== modified file 'tests/CMakeLists.txt'
34--- tests/CMakeLists.txt 2013-05-14 14:50:59 +0000
35+++ tests/CMakeLists.txt 2013-06-03 16:41:27 +0000
36@@ -178,7 +178,6 @@
37 #test-bad-app-info-missing-menus
38 #test-bad-app-info-multiple-menus
39 #test-good-app-info-tons-of-entries
40-#test-dbus-message-count
41
42 ####################################
43 # Voice tests (needs working pulse)
44
45=== removed file 'tests/test-dbus-message-count.in'
46--- tests/test-dbus-message-count.in 2013-03-25 21:16:02 +0000
47+++ tests/test-dbus-message-count.in 1970-01-01 00:00:00 +0000
48@@ -1,21 +0,0 @@
49-#!/bin/bash
50-
51-export DISPLAY=
52-
53-. @srcdir@/run-xvfb.sh
54-
55-dbus-test-runner \
56- --max-wait 10 \
57- -b @builddir@/test-dbus-message-count.bustle \
58- --task /usr/bin/metacity --task-name metacity \
59- --task /usr/lib/bamf/bamfdaemon --task-name bamf \
60- --task @top_builddir@/src/hud-service --task-name hud --wait-for org.ayatana.bamf \
61- --task /usr/lib/libindicator/indicator-loader3 --parameter @indicatordir@/libappmenu.so --task-name appmenu --wait-for org.ayatana.bamf \
62- --task @mockjsonapp@ --parameter @srcdir@/test-dbus-message-count.json --wait-for com.canonical.AppMenu.Registrar --task-name app \
63- --task @srcdir@/test-dbus-message-count-send-query --wait-for com.canonical.AppMenu.Registrar --task-name query
64-
65-sleep 1
66-
67-if which bustle; then
68- bustle --count test-dbus-message-count.bustle
69-fi

Subscribers

People subscribed via source and target branches