Merge lp:~ted/gnome-session/upstart-unity into lp:~ubuntu-desktop/gnome-session/ubuntu

[Ted Gould]

Makes it so that Upstart is used to start Unity and GNOME Settings Daemon instead of having GNOME Session do it. The Unity Upstart jobs have been tested by several people for a while and seem stable. It seems like a good time to transition over to using them by default.

[James Hunt (jamesodhunt)]

LGTM.

[Stéphane Graber (stgraber)]

That's fine, though you should probably clearly state that from this point on, it won't be possible to start a Unity session without upstart user sessions.

Also a quick note (unrelated to this diff), please don't remove the gnome-settings-daemon.desktop override file in upstart as even though it won't be needed for Unity anymore, it'll still be used by all the other sessions using gnome-session.

[Sebastien Bacher (seb128)]

Thanks Ted, I tried but it leads to visual regression on login (I see a white background then some fading in of the background, it's visually unpleasant)

gnome-session ensure that the settings (theme, etc) are set early and roll important services first, maybe we need to order the start as well ...

is anyone else seeing such glitches with that patch?

review: Needs Fixing

[Ted Gould (ted)]

I'm seeing a slight flash, but I think it's Nautilus starting.
Currently the Unity job is set to wait until g-s-d is started. Do you
think there's anything else we should wait on?

[Sebastien Bacher (seb128)]

Not sure what's the issue, but that doesn't happen when gnome-session start those services ...

[Jeremy Bícha (jbicha)]

upstart has been removed from Ubuntu 17.10 so I'm closing this merge proposal.

review: Disapprove

Unmerged revisions

283. By Ted Gould on 2013-07-02

* debian/patches/50_ubuntu_sessions.patch:
  - Let upstart start Compiz and GNOME Settings Daemon instead of having
    GNOME Session do it.

=== modified file 'debian/changelog'
--- debian/changelog	2013-06-25 15:09:48 +0000
+++ debian/changelog	2013-07-02 20:34:43 +0000
@@ -1,3 +1,11 @@
+gnome-session (3.8.2.1-1ubuntu5) UNRELEASED; urgency=low
+
+  * debian/patches/50_ubuntu_sessions.patch:
+    - Let upstart start Compiz and GNOME Settings Daemon instead of having
+      GNOME Session do it.
+
+ -- Ted Gould <[e-mail]>  Tue, 02 Jul 2013 15:19:03 -0500
+
 gnome-session (3.8.2.1-1ubuntu4) saucy; urgency=low
 
   * debian/patches/22_support_autostart_delay.patch: 

=== modified file 'debian/patches/50_ubuntu_sessions.patch'
--- debian/patches/50_ubuntu_sessions.patch	2013-06-08 23:25:03 +0000
+++ debian/patches/50_ubuntu_sessions.patch	2013-07-02 20:34:43 +0000
@@ -47,7 +47,7 @@
 @@ -0,0 +1,3 @@
 +[GNOME Session]
 +_Name=Ubuntu
-+RequiredComponents=gnome-settings-daemon;compiz;
++RequiredComponents=
 Index: gnome-session-3.7.4/data/ubuntu.desktop.in
 ===================================================================
 --- /dev/null	1970-01-01 00:00:00.000000000 +0000

=== modified file 'debian/patches/52_xdg_current_desktop.patch'
--- debian/patches/52_xdg_current_desktop.patch	2013-06-08 23:25:03 +0000
+++ debian/patches/52_xdg_current_desktop.patch	2013-07-02 20:34:43 +0000
@@ -5,7 +5,7 @@
 @@ -1,3 +1,4 @@
  [GNOME Session]
  _Name=Ubuntu
- RequiredComponents=gnome-settings-daemon;compiz;
+ RequiredComponents=
 +DesktopName=Unity
 Index: gnome-session-3.7.4/gnome-session/gsm-session-fill.c
 ===================================================================