Merge lp:~ted/evolution-indicator/plural-forms into lp:evolution-indicator

Proposed by Ted Gould
Status: Merged
Merged at revision: not available
Proposed branch: lp:~ted/evolution-indicator/plural-forms
Merge into: lp:evolution-indicator
Diff against target: 14 lines (+2/-2)
1 file modified
src/evolution-indicator.c (+2/-2)
To merge this branch: bzr merge lp:~ted/evolution-indicator/plural-forms
Reviewer Review Type Date Requested Status
David Planella (community) Approve
Indicator Applet Developers Pending
Review via email:

Description of the change

Remove an extra set of _() function calls that are messing up the
ngettext call.

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :


If you could please review the practicality of submitting this at this point in the release cycle. On one hand it helps translators, on the other hand it invalidates a bunch of strings.


Revision history for this message
Ted Gould (ted) wrote :

Where a bunch is two in English.

Revision history for this message
David Planella (dpm) wrote :

Thanks Ted for letting me know about this change.

I think it's worth applying it.

It will break the translations of two messages, but on the other hand, it will mean plurals will be correctly translated for languages with more than two plurals.

The resulting plural message is easy enough to translate, it might be that global translation suggestions appear from the existing translation of the Karmic version [1] (meaning that many translation teams will only have to point and click to translate), and if properly communicated to translation teams (announcement to the ubuntu-translators@ list) it will end up translated as usual.


Revision history for this message
David Planella (dpm) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/evolution-indicator.c'
2--- src/evolution-indicator.c 2010-03-04 05:05:05 +0000
3+++ src/evolution-indicator.c 2010-03-29 21:50:30 +0000
4@@ -292,8 +292,8 @@
5 }
7 trans = g_dngettext (PACKAGE,
8- _("%d New Message"),
9- _("%d New Messages"),
10+ "%d New Message",
11+ "%d New Messages",
12 message_count);
14 title = g_strdup_printf (trans, message_count);


People subscribed via source and target branches