Merge lp:~ted/evolution-indicator/plural-forms into lp:evolution-indicator

[Ted Gould]

Remove an extra set of _() function calls that are messing up the
ngettext call.

[Ted Gould (ted)]

David,

If you could please review the practicality of submitting this at this point in the release cycle. On one hand it helps translators, on the other hand it invalidates a bunch of strings.

Thanks,
Ted

[Ted Gould (ted)]

Where a bunch is two in English.

[David Planella (dpm)]

Thanks Ted for letting me know about this change.

I think it's worth applying it.

It will break the translations of two messages, but on the other hand, it will mean plurals will be correctly translated for languages with more than two plurals.

The resulting plural message is easy enough to translate, it might be that global translation suggestions appear from the existing translation of the Karmic version [1] (meaning that many translation teams will only have to point and click to translate), and if properly communicated to translation teams (announcement to the ubuntu-translators@ list) it will end up translated as usual.

[1] https://translations.launchpad.net/ubuntu/karmic/+source/evolution-indicator/+pots/evolution-indicator/en_GB/+translate

[David Planella (dpm)]

review: Approve

=== modified file 'src/evolution-indicator.c'
--- src/evolution-indicator.c	2010-03-04 05:05:05 +0000
+++ src/evolution-indicator.c	2010-03-29 21:50:30 +0000
@@ -292,8 +292,8 @@
     }
 
     trans = g_dngettext (PACKAGE, 
-                         _("%d New Message"), 
-                         _("%d New Messages"),
+                         "%d New Message", 
+                         "%d New Messages",
                          message_count);
     
     title = g_strdup_printf (trans, message_count);