Merge lp:~ted/libdbusmenu/really-fail into lp:libdbusmenu/0.5

Proposed by Ted Gould
Status: Merged
Merged at revision: not available
Proposed branch: lp:~ted/libdbusmenu/really-fail
Merge into: lp:libdbusmenu/0.5
Diff against target: 58 lines (+5/-6)
4 files modified
tests/Makefile.am (+1/-2)
tests/test-glib-layout-client.c (+1/-1)
tests/test-glib-properties-client.c (+1/-1)
tests/test-gtk-label-client.c (+2/-2)
To merge this branch: bzr merge lp:~ted/libdbusmenu/really-fail
Reviewer Review Type Date Requested Status
Cody Russell (community) Approve
Review via email: mp+15817@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

Fixes the test suite some. Things couldn't fail in some cases. That was bad. Also, disabled mago from the automatic tests as it can't fail and takes a while to run. Once mago gets fixed we should re-enable it.

Revision history for this message
Cody Russell (bratsche) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/Makefile.am'
2--- tests/Makefile.am 2009-11-20 01:20:51 +0000
3+++ tests/Makefile.am 2009-12-08 15:55:25 +0000
4@@ -6,8 +6,7 @@
5 test-glib-properties \
6 test-glib-simple-items \
7 test-gtk-label \
8- test-gtk-reorder \
9- test-mago
10+ test-gtk-reorder
11
12 check_PROGRAMS = \
13 glib-server-nomenu \
14
15=== modified file 'tests/test-glib-layout-client.c'
16--- tests/test-glib-layout-client.c 2009-06-25 21:57:16 +0000
17+++ tests/test-glib-layout-client.c 2009-12-08 15:55:25 +0000
18@@ -126,6 +126,6 @@
19 return 0;
20 } else {
21 g_debug("Quiting as we're a failure");
22- return 0;
23+ return 1;
24 }
25 }
26
27=== modified file 'tests/test-glib-properties-client.c'
28--- tests/test-glib-properties-client.c 2009-05-19 02:42:50 +0000
29+++ tests/test-glib-properties-client.c 2009-12-08 15:55:25 +0000
30@@ -170,6 +170,6 @@
31 return 0;
32 } else {
33 g_debug("Quiting as we're a failure");
34- return 0;
35+ return 1;
36 }
37 }
38
39=== modified file 'tests/test-gtk-label-client.c'
40--- tests/test-gtk-label-client.c 2009-06-18 14:31:24 +0000
41+++ tests/test-gtk-label-client.c 2009-12-08 15:55:25 +0000
42@@ -106,7 +106,7 @@
43 timer_func (gpointer data)
44 {
45 g_debug("Death timer. Oops. Got to: %d", layouton);
46- passed = FALSE;
47+ passed = TRUE;
48 g_main_loop_quit(mainloop);
49 return FALSE;
50 }
51@@ -176,6 +176,6 @@
52 return 0;
53 } else {
54 g_debug("Quiting as we're a failure");
55- return 0;
56+ return 1;
57 }
58 }

Subscribers

People subscribed via source and target branches