DBus Menu

Merge lp:~ted/libdbusmenu/default-xml-id into lp:libdbusmenu/0.5

  1. default-xml-id
  2. Merge into trunk
Proposed by Ted Gould
Status: Merged
Merged at revision: not available
Proposed branch: lp:~ted/libdbusmenu/default-xml-id
Merge into: lp:libdbusmenu/0.5
Diff against target: 12 lines (+1/-1)
1 file modified
libdbusmenu-glib/server.c (+1/-1)
To merge this branch: bzr merge lp:~ted/libdbusmenu/default-xml-id
Reviewer Review Type Date Requested Status
Cody Russell (community) Approve
Review via email: mp+19202@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

This patch changes the default XML file sent with the layout to have an
ID on it. It really always should have, and since the root item has a
fixed ID, there is a good one for us to give it too :)

Revision history for this message
Cody Russell (bratsche) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-glib/server.c'
2--- libdbusmenu-glib/server.c 2010-02-09 16:52:21 +0000
3+++ libdbusmenu-glib/server.c 2010-02-12 21:10:27 +0000
4@@ -378,7 +378,7 @@
5 if (parent == 0) {
6 if (priv->root == NULL) {
7 /* g_debug("Getting layout without root node!"); */
8- g_ptr_array_add(xmlarray, g_strdup("<menu/>"));
9+ g_ptr_array_add(xmlarray, g_strdup("<menu id=\"0\"/>"));
10 } else {
11 dbusmenu_menuitem_buildxml(priv->root, xmlarray);
12 }

Subscribers

People subscribed via source and target branches