DBus Test Runner

Merge lp:~ted/dbus-test-runner/lp1260779 into lp:dbus-test-runner/14.04

Proposed by Ted Gould on 2013-12-13

Status:

Merged

Approved by:

Charles Kerr on 2013-12-18

Approved revision:

Merged at revision:

Proposed branch:

Merge into:

Diff against target:

1 file modified

libdbustest/process.c (+1/-0)

To merge this branch:

bzr merge lp:~ted/dbus-test-runner/lp1260779

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Charles Kerr (community)		2013-12-13	Approve on 2013-12-18
PS Jenkins bot (community)	continuous-integration		Approve on 2013-12-13
Review via email: mp+198987@code.launchpad.net

Make sure to not clear the watcher if it fired

Sometimes processes die. We can not morn their death unnecssiarily, but we must be aware and handle the problems of their death reponsibly.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-12-13:

review: Approve (continuous-integration)

Revision history for this message

Charles Kerr (charlesk) wrote on 2013-12-18:

Epic.

review: Approve

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

1	=== modified file 'libdbustest/process.c'
2	--- libdbustest/process.c 2013-11-18 18:34:08 +0000
3	+++ libdbustest/process.c 2013-12-13 19:00:01 +0000
4	@@ -253,6 +253,7 @@
5
6	process->priv->complete = TRUE;
7	process->priv->status = status;
8	+ process->priv->watcher = 0;
9
10	if (status) {
11	message = g_strdup_printf("Exited with status %d", status);