Merge lp:~ted/dbus-test-runner/fix-coverage into lp:dbus-test-runner/0.1

[Ted Gould]

Provides more tests and some testability to dbus-test-runner. All motivated to increase the code coverage of the test suite.

[Neil J. Patel (njpatel)]

Looks good, approved.

review: Approve

=== modified file 'src/dbus-test-runner.c'
--- src/dbus-test-runner.c	2011-11-28 22:21:06 +0000
+++ src/dbus-test-runner.c	2011-12-10 03:58:25 +0000
@@ -49,13 +49,15 @@
 
 static void check_task_cleanup (task_t * task, gboolean force);
 static void start_task (gpointer data, gpointer userdata);
+static void bustle_watcher (GPid pid, gint status, gpointer data);
 
+static gchar * bustle_cmd = NULL;
 static gchar * bustle_datafile = NULL;
+static guint bustle_watch = 0;
 static GIOChannel * bustle_stdout = NULL;
 static GIOChannel * bustle_stderr = NULL;
 static GIOChannel * bustle_file = NULL;
 static GPid bustle_pid = 0;
-static GList * bustle_watches = NULL;
 static gboolean any_waitfors = FALSE;
 
 #define BUSTLE_ERROR_DEFAULT  "Bustle"
@@ -127,29 +129,27 @@
 	bustle_file = g_io_channel_new_file(bustle_datafile, "w", &error);
 
 	if (error != NULL) {
-		g_warning("Unable to open bustle file '%s': %s", bustle_datafile, error->message);
+		g_critical("Unable to open bustle file '%s': %s", bustle_datafile, error->message);
 		g_error_free(error);
 		g_free(bustle_datafile);
 		bustle_datafile = NULL;
+		global_success = FALSE;
+		g_main_loop_quit(global_mainloop);
 		return;
 	}
 
 	gint bustle_stdout_num;
 	gint bustle_stderr_num;
 	
-	gchar ** bustle_monitor = g_new0(gchar *, g_list_length(bustle_watches) + 3);
-	bustle_monitor[0] = "bustle-dbus-monitor";
+	gchar ** bustle_monitor = g_new0(gchar *, 3);
+	bustle_monitor[0] = (gchar *)bustle_cmd;
 	bustle_monitor[1] = "--session";
-	int i;
-	for (i = 0; i < g_list_length(bustle_watches); i++) {
-		bustle_monitor[i + 2] = (gchar *)g_list_nth(bustle_watches, i)->data;
-	}
 
 	g_spawn_async_with_pipes(g_get_current_dir(),
 	                         bustle_monitor, /* argv */
 	                         NULL, /* envp */
 	                         /* G_SPAWN_SEARCH_PATH | G_SPAWN_STDERR_TO_DEV_NULL, */ /* flags */
-	                         G_SPAWN_SEARCH_PATH, /* flags */
+	                         G_SPAWN_SEARCH_PATH | G_SPAWN_DO_NOT_REAP_CHILD, /* flags */
 	                         NULL, /* child setup func */
 	                         NULL, /* child setup data */
 	                         &bustle_pid, /* PID */
@@ -159,11 +159,16 @@
 	                         &error); /* error */
 
 	if (error != NULL) {
-		g_warning("Unable to start bustling data: %s", error->message);
+		g_critical("Unable to start bustling data: %s", error->message);
+		g_error_free(error);
+		bustle_pid = 0;
+		global_success = FALSE;
+		g_main_loop_quit(global_mainloop);
 		return;
 	}
 
 	g_debug("Starting bustle monitor.  PID: %d", bustle_pid);
+	bustle_watch = g_child_watch_add(bustle_pid, bustle_watcher, NULL);
 
 	bustle_stdout = g_io_channel_unix_new(bustle_stdout_num);
 	g_io_add_watch(bustle_stdout,
@@ -187,6 +192,14 @@
 		return;
 	}
 
+	if (bustle_watch != 0) {
+		g_source_remove(bustle_watch);
+	}
+
+	if (bustle_pid == 0) {
+		return;
+	}
+
 	gchar * killline = g_strdup_printf("kill -INT %d", bustle_pid);
 	g_spawn_command_line_sync(killline, NULL, NULL, NULL, NULL);
 	g_free(killline);
@@ -281,6 +294,36 @@
 }
 
 static void
+dbus_watcher (GPid pid, gint status, gpointer data)
+{
+	g_critical("DBus Daemon exited abruptly!");
+
+	global_success = FALSE;
+	g_main_loop_quit(global_mainloop);
+
+	if (pid != 0) {
+		g_spawn_close_pid(pid);
+	}
+
+	return;
+}
+
+static void
+bustle_watcher (GPid pid, gint status, gpointer data)
+{
+	g_critical("Bustle Monitor exited abruptly!");
+
+	global_success = FALSE;
+	g_main_loop_quit(global_mainloop);
+
+	if (pid != 0) {
+		g_spawn_close_pid(pid);
+	}
+
+	return;
+}
+
+static void
 proc_watcher (GPid pid, gint status, gpointer data)
 {
 	task_t * task = (task_t *)data;
@@ -404,7 +447,7 @@
 dbus_writes (GIOChannel * channel, GIOCondition condition, gpointer data)
 {
 	if (condition & G_IO_ERR) {
-		g_error("DBus writing failure!");
+		g_critical("DBus writing failure!");
 		return FALSE;
 	}
 
@@ -427,9 +470,14 @@
 		if (tasks != NULL) {
 			start_bustling();
 
-			g_list_foreach(tasks, start_task, GINT_TO_POINTER(FALSE));
+			/* If we're still in a place where we can succeed, then
+			   we should continue.  Otherwise fail. */
+			if (global_success) {
+				g_list_foreach(tasks, start_task, GINT_TO_POINTER(FALSE));
+			}
 		} else {
 			g_print("No tasks!\n");
+			global_success = FALSE;
 			g_main_loop_quit(global_mainloop);
 		}
 	}
@@ -540,13 +588,6 @@
 	return TRUE;
 }
 
-static gboolean
-bustle_watch (const gchar * arg, const gchar * value, gpointer data, GError ** error)
-{
-	bustle_watches = g_list_append(bustle_watches, g_strdup(value));
-	return TRUE;
-}
-
 static void
 length_finder (gpointer data, gpointer udata)
 {
@@ -636,11 +677,13 @@
 }
 
 static gchar * dbus_configfile = NULL;
+static gchar * dbus_daemon = NULL;
 
 static GOptionEntry general_options[] = {
+	{"dbus-daemon",  0,     0,                       G_OPTION_ARG_FILENAME,  &dbus_daemon,     "Path to the DBus deamon to use.  Defaults to 'dbus-daemon'.", "executable"},
 	{"dbus-config",  'd',   0,                       G_OPTION_ARG_FILENAME,  &dbus_configfile, "Configuration file for newly created DBus server.  Defaults to '" DEFAULT_SESSION_CONF "'.", "config_file"},
+	{"bustle-monitor", 0,   0,                       G_OPTION_ARG_FILENAME,  &bustle_cmd,      "Path to the Bustle DBus Monitor to use.  Defaults to 'bustle-dbus-monitor'.", "executable"},
 	{"bustle-data",  'b',   0,                       G_OPTION_ARG_FILENAME,  &bustle_datafile, "A file to write out data from the bustle logger to.", "data_file"},
-	{"bustle-watch", 'w',   0,                       G_OPTION_ARG_CALLBACK,  bustle_watch,     "Defines a watch string for the bustle watcher task. (broken)", "filter"},
 	{"max-wait",     'm',   0,                       G_OPTION_ARG_INT,       &max_wait,        "The maximum amount of time the test runner will wait for the test to complete.  Default is 30 seconds.", "seconds"},
 	{NULL}
 };
@@ -683,21 +726,36 @@
 		dbus_configfile = DEFAULT_SESSION_CONF;
 	}
 
+	if (dbus_daemon == NULL) {
+		dbus_daemon = "dbus-daemon";
+	}
+
+	if (bustle_cmd == NULL) {
+		bustle_cmd = "bustle-dbus-monitor";
+	}
+
 	gint dbus_stdout;
 	GPid dbus;
 	gchar * blank[1] = {NULL};
-	gchar * dbus_startup[] = {"dbus-daemon", "--config-file", dbus_configfile, "--print-address", NULL};
+	gchar * dbus_startup[] = {dbus_daemon, "--config-file", dbus_configfile, "--print-address", NULL};
 	g_spawn_async_with_pipes(g_get_current_dir(),
 	                         dbus_startup, /* argv */
 	                         blank, /* envp */
-	                         G_SPAWN_SEARCH_PATH, /* flags */
+	                         G_SPAWN_SEARCH_PATH | G_SPAWN_DO_NOT_REAP_CHILD, /* flags */
 	                         NULL, /* child setup func */
 	                         NULL, /* child setup data */
 							 &dbus, /* PID */
 	                         NULL, /* stdin */
 	                         &dbus_stdout, /* stdout */
 	                         NULL, /* stderr */
-	                         NULL); /* error */
+	                         &error); /* error */
+
+	if (error != NULL) {
+		g_critical("Unable to start dbus daemon: %s", error->message);
+		return 1;
+	}
+
+	guint dbus_watch = g_child_watch_add(dbus, dbus_watcher, NULL);
 
 	GIOChannel * dbus_io = g_io_channel_unix_new(dbus_stdout);
 	g_io_add_watch(dbus_io,
@@ -714,6 +772,7 @@
 
 	stop_bustling();
 
+	g_source_remove(dbus_watch); /* Let's not error when we want to kill it */
 	gchar * killline = g_strdup_printf("kill -9 %d", dbus);
 	g_spawn_command_line_sync(killline, NULL, NULL, NULL, NULL);
 	g_free(killline);

=== modified file 'tests/Makefile.am'
--- tests/Makefile.am	2011-11-28 22:21:06 +0000
+++ tests/Makefile.am	2011-12-10 03:58:25 +0000
@@ -1,5 +1,5 @@
 
-DBUS_RUNNER=../src/dbus-test-runner --dbus-config $(srcdir)/../data/session.conf
+DBUS_RUNNER=$(top_builddir)/src/dbus-test-runner --dbus-config $(srcdir)/../data/session.conf
 TESTS = 
 DISTCLEANFILES = $(TESTS)
 XFAIL_TESTS =
@@ -57,6 +57,96 @@
 	@chmod +x $@
 XFAIL_TESTS += test-timeout
 
+TESTS += test-timeout-disable
+test-timeout-disable: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --max-wait 0 --task true >> $@
+	@chmod +x $@
+
+TESTS += test-param-only-name
+test-param-only-name: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --task-name Name >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-param-only-name
+
+TESTS += test-param-dup-name
+test-param-dup-name: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --task true --task-name Name --task-name Name2 >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-param-dup-name
+
+TESTS += test-param-only-ignore
+test-param-only-ignore: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --ignore-return >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-param-only-ignore
+
+TESTS += test-param-only-invert
+test-param-only-invert: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --invert-return >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-param-only-invert
+
+TESTS += test-param-multi-return-invert
+test-param-multi-return-invert: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --task true --ignore-return --invert-return >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-param-multi-return-invert
+
+TESTS += test-param-multi-return-ignore
+test-param-multi-return-ignore: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --task true --invert-return --ignore-return >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-param-multi-return-ignore
+
+TESTS += test-param-only-param
+test-param-only-param: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --parameter bob >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-param-only-param
+
+TESTS += test-param-only-wait
+test-param-only-wait: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --wait-for org.test.test >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-param-only-wait
+
+TESTS += test-param-multi-wait
+test-param-multi-wait: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --task true --wait-for org.test.test --wait-for org.test.test2 >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-param-multi-wait
+
+TESTS += test-param-bad
+test-param-bad: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --this-is-most-surly-not-a-real-parameter >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-param-bad
+
+TESTS += test-param-bad-task
+test-param-bad-task: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --task this-is-most-surly-not-a-real-program >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-param-bad-task
+
+TESTS += test-no-tasks
+test-no-tasks: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-no-tasks
+
 TESTS += test-output
 test-output: Makefile.am
 	@echo "#!/bin/sh -e" > $@
@@ -85,6 +175,29 @@
 	@chmod +x $@
 DISTCLEANFILES += test-bustle.bustle test-bustle.filtered
 
+TESTS += test-bustle-bad-file
+test-bustle-bad-file: Makefile.am
+	@echo "#!/bin/sh -e" > $@
+	@echo $(DBUS_RUNNER) --bustle-data \"$(builddir)\" --task true >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-bustle-bad-file
+
+TESTS += test-bustle-bad-monitor
+test-bustle-bad-monitor: Makefile.am
+	@echo "#!/bin/sh -e" > $@
+	@echo $(DBUS_RUNNER) --bustle-monitor probably-doesnt-exist --bustle-data \"$(builddir)/test-bustle-bad-monitor.bustle\" --task true >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-bustle-bad-monitor
+DISTCLEANFILES += test-bustle-bad-monitor.bustle
+
+TESTS += test-bustle-bad-monitor-error
+test-bustle-bad-monitor-error: Makefile.am
+	@echo "#!/bin/sh -e" > $@
+	@echo $(DBUS_RUNNER) --bustle-monitor sleep --bustle-data \"$(builddir)/test-bustle-bad-monitor-error.bustle\" --task true >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-bustle-bad-monitor-error
+DISTCLEANFILES += test-bustle-bad-monitor-error.bustle
+
 TESTS += test-bustle-data
 test-bustle-data: Makefile.am
 	@echo "#!/bin/sh -e" > $@
@@ -126,6 +239,32 @@
 	@echo $(DBUS_RUNNER) --task $(builddir)/test-check-name --parameter org.test.name --wait-for org.test.name --task $(builddir)/test-own-name --parameter org.test.name --ignore-return >> $@
 	@chmod +x $@
 
+TESTS += test-daemon-bad
+test-daemon-bad: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --dbus-daemon false --task true >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-daemon-bad
+
+TESTS += test-daemon-missing
+test-daemon-missing: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --dbus-daemon probably-doesnt-exist --task true >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-daemon-missing
+
+TESTS += test-daemon-junk
+test-daemon-junk: Makefile.am test-daemon-junk-spitter
+	@echo "#!/bin/sh" > $@
+	@echo $(DBUS_RUNNER) --dbus-daemon $(builddir)/test-daemon-junk-spitter --task true >> $@
+	@chmod +x $@
+test-daemon-junk-spitter: Makefile.am
+	@echo "#!/bin/sh" > $@
+	@echo cat $(top_builddir)/src/dbus-test-runner >> $@
+	@chmod +x $@
+XFAIL_TESTS += test-daemon-junk
+DISTCLEANFILES += test-daemon-junk-spitter
+
 EXTRA_DIST = \
 	delayrm.sh \
 	test-bustle.reference \