Merge lp:~techmagus/quam-plures/qp-bug522609 into lp:quam-plures

Proposed by I'M YourOnly.One 🔏
Status: Merged
Merge reported by: Yabs
Merged at revision: not available
Proposed branch: lp:~techmagus/quam-plures/qp-bug522609
Merge into: lp:quam-plures
Diff against target: 36 lines (+4/-4)
2 files modified
admin.php (+1/-1)
install/index.php (+3/-3)
To merge this branch: bzr merge lp:~techmagus/quam-plures/qp-bug522609
Reviewer Review Type Date Requested Status
Yabs (community) Approve
Review via email: mp+19579@code.launchpad.net

Commit message

Fix for Bug 522609

To post a comment you must log in.
Revision history for this message
I'M YourOnly.One 🔏 (techmagus) wrote :
Revision history for this message
Yabs (yabs) wrote :

I'm sure there'll be a load more of these lying around in the core, we need to kill them all as we find them ;)

¥

review: Approve
Revision history for this message
EdB (edb) wrote :

I didn't know "= & new" was bad. Now that I know that, bad =&new - BAD!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'admin.php'
2--- admin.php 2010-01-04 17:32:41 +0000
3+++ admin.php 2010-02-18 07:36:20 +0000
4@@ -165,7 +165,7 @@
5 *
6 * @global AdminUI
7 */
8-$AdminUI = & new AdminUI();
9+$AdminUI = new AdminUI();
10
11
12 /*
13
14=== modified file 'install/index.php'
15--- install/index.php 2010-01-16 17:30:37 +0000
16+++ install/index.php 2010-02-18 07:36:20 +0000
17@@ -39,8 +39,8 @@
18 require_once $inc_path.'_core/_misc.funcs.php';
19
20 load_class('_core/model/_log.class.php');
21-$Debuglog = & new Log( 'note' );
22-$Messages = & new Log('error');
23+$Debuglog = new Log( 'note' );
24+$Messages = new Log('error');
25 require_once $conf_path.'_upgrade.php';
26 require_once $inc_path.'_vars.inc.php';
27 load_class('/_core/model/db/_db.class.php');
28@@ -54,7 +54,7 @@
29 load_class('plugins/model/_plugins.class.php');
30 require_once dirname(__FILE__).'/_functions_install.php';
31
32-$Timer = & new Timer('main');
33+$Timer = new Timer('main');
34
35 load_funcs('_core/_param.funcs.php');
36 param( 'action', 'string', 'default' );

Subscribers

People subscribed via source and target branches