Merge lp:~team-cluster/openerp-venezuela-localization/7.0-wh-islr-get-partner-address-eochoa into lp:openerp-venezuela-localization

Proposed by Eduardo Ochoa - Cluster Brands
Status: Merged
Approved by: hbto [Vauxoo] http://www.vauxoo.com
Approved revision: 939
Merged at revision: 939
Proposed branch: lp:~team-cluster/openerp-venezuela-localization/7.0-wh-islr-get-partner-address-eochoa
Merge into: lp:openerp-venezuela-localization
Diff against target: 32 lines (+3/-3)
2 files modified
l10n_ve_withholding_islr/report/wh_islr.py (+1/-1)
l10n_ve_withholding_islr/report/wh_islr_report.rml (+2/-2)
To merge this branch: bzr merge lp:~team-cluster/openerp-venezuela-localization/7.0-wh-islr-get-partner-address-eochoa
Reviewer Review Type Date Requested Status
hbto [Vauxoo] http://www.vauxoo.com Approve
Review via email: mp+198116@code.launchpad.net

Description of the change

Saludos,

Aca dejo algunas correcciones que realizamos al reporte Comprobante ISLR:

-Formateado el campo date_ret del reporte para que se ajuste al idioma seleccionado
-Modificada la función _get_partner_address para quitarle la condición que especificaba
que la dirección fuese tipo 'default' lo que ocasionaba que la misma
no se mostrara para algunos partners que tengan otro tipo (Por Ejempo: 'Contact')

To post a comment you must log in.
Revision history for this message
hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'l10n_ve_withholding_islr/report/wh_islr.py'
2--- l10n_ve_withholding_islr/report/wh_islr.py 2013-08-22 13:46:48 +0000
3+++ l10n_ve_withholding_islr/report/wh_islr.py 2013-12-06 19:16:27 +0000
4@@ -47,7 +47,7 @@
5 addr_inv={}
6 if idp:
7 addr = addr_obj.browse(self.cr,self.uid, idp)
8- addr_inv = addr.type == 'default' and (addr.street and ('%s, '%addr.street.title()) or '') + \
9+ addr_inv = (addr.street and ('%s, '%addr.street.title()) or '') + \
10 (addr.zip and ('Codigo Postal: %s, '%addr.zip) or '') +\
11 (addr.city and ('%s, '%addr.city.title()) or '')+ \
12 (addr.state_id and ('%s, '%addr.state_id.name.title()) or '')+ \
13
14=== modified file 'l10n_ve_withholding_islr/report/wh_islr_report.rml'
15--- l10n_ve_withholding_islr/report/wh_islr_report.rml 2013-08-22 13:46:48 +0000
16+++ l10n_ve_withholding_islr/report/wh_islr_report.rml 2013-12-06 19:16:27 +0000
17@@ -66,7 +66,7 @@
18 </td>
19 <td>
20 <para style="TCENTER">
21- <b>[[ o.date_ret ]]</b>
22+ <b>[[formatLang(o.date_ret, date=True]]</b>
23 </para>
24 </td>
25 <td>
26@@ -271,4 +271,4 @@
27 </blockTable>
28
29 </story>
30-</document>
31\ No newline at end of file
32+</document>