Code review comment for lp:~tdfischer/zeitgeist/common-where

Revision history for this message
Siegfried Gevatter (rainct) wrote :

Hey,

Thanks for splitting this out :).

> public uint32[] find_event_ids_for_clause (WhereClause where,
> uint max_events, uint result_type,
> BusName? sender=null) throws EngineError

This method isn't using `sender' anywhere (nor should it), so drop that argument.

> public WhereClause get_where_clause_for_query

Same here.

review: Needs Fixing

« Back to merge proposal