Merge lp:~tdelaet/entertainer/fixes-for-future-branch into lp:entertainer/future
Proposed by
Thomas Delaet
Status: | Rejected |
---|---|
Rejected by: | Matt Layman |
Proposed branch: | lp:~tdelaet/entertainer/fixes-for-future-branch |
Merge into: | lp:entertainer/future |
Diff against target: |
32 lines (+6/-1) 2 files modified
entertainerlib/client/media_player.py (+1/-1) entertainerlib/gui/user_interface.py (+5/-0) |
To merge this branch: | bzr merge lp:~tdelaet/entertainer/fixes-for-future-branch |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Matt Layman | Needs Fixing | ||
Review via email: mp+20254@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 387. By Thomas Delaet <thomas@cole>
-
get_playbin does not exist anymore in recent pyclutter-gst bindings. use correct name.
- 386. By Thomas Delaet <thomas@cole>
-
When a video is finished, the screens turns blue.
The reason for this is that the video_osd screen does not change to another screen and the video texture is removed when playing is done.
This commit fixes the problem: when the user interface detects the stop event from the media player, it switches to the previous screen
This branch fixes two problems I had when trying out the entertainer future branch.
1. The latest version of pyclutter-gst doesn't have the get_playbin() function anymore. This function is renamed to get_pipeline(). (see changelog of pyclutter-gst)
2. When a video is finished playing, my screen turns blue. I fixed this by subscribing to the 'stop' signal of the media player. When the user interface receives this signal, it changes the screen to the previous screen.
See in commit messages for more details.