Merge ~tcuthbert/turku:main into turku:main

Proposed by Thomas Cuthbert
Status: Approved
Approved by: Thomas Cuthbert
Approved revision: 68ac6ef202029e7875a8fee065b763154f1f66d5
Proposed branch: ~tcuthbert/turku:main
Merge into: turku:main
Diff against target: 13 lines (+1/-1)
1 file modified
turku_storage/ping.py (+1/-1)
Reviewer Review Type Date Requested Status
Thomas Cuthbert (community) Approve
James Simpson Approve
Review via email: mp+411917@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Simpson (jsimpso) wrote :

LGTM, one comment

review: Approve
Revision history for this message
Thomas Cuthbert (tcuthbert) wrote :

reply inline.

review: Approve

Unmerged commits

68ac6ef... by Thomas Cuthbert

Import from Bazaar to Git

35bcfcf... by Laurent Sesquès

fix usage of --hard-links when preserve_hard_links is set for a source

Reviewed-on: https://code.launchpad.net/~sajoupa/turku/turku-storage-hard-link/+merge/410395
Reviewed-by: Tom Haddon <email address hidden>
Reviewed-by: Colin Watson <email address hidden>

feb6f8f... by Laurent Sesquès

also check the global config for preserve_hard_links

b05ed22... by Laurent Sesquès

fix usage of --hard-links when preserve_hard_links is set for a source

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/turku_storage/ping.py b/turku_storage/ping.py
2index 60355ab..eb36c7a 100644
3--- a/turku_storage/ping.py
4+++ b/turku_storage/ping.py
5@@ -256,7 +256,7 @@ class StoragePing:
6 )
7 else:
8 rsync_args.append("--inplace")
9- if self.config["preserve_hard_links"]:
10+ if self.config["preserve_hard_links"] or ("preserve_hard_links" in s and s["preserve_hard_links"]):
11 rsync_args.append("--hard-links")
12
13 filter_file = None

Subscribers

People subscribed via source and target branches

to all changes: