Merge ~tcuthbert/charm-mongodb:master into ~mongodb-charmers/charm-mongodb:master
Proposed by
Thomas Cuthbert
Status: | Merged |
---|---|
Approved by: | Thomas Cuthbert |
Approved revision: | 76df3b0c81cb9c8e3de0ce09898c70c89f2c2d93 |
Merged at revision: | 7e6f2361252055c19e8f70752d071eecc17e468e |
Proposed branch: | ~tcuthbert/charm-mongodb:master |
Merge into: | ~mongodb-charmers/charm-mongodb:master |
Diff against target: |
170 lines (+67/-22) 2 files modified
config.yaml (+2/-2) hooks/hooks.py (+65/-20) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop (community) | Approve | ||
Review via email: mp+349115@code.launchpad.net |
Commit message
Initial implementation of bionic support
Description of the change
CI test here:
bionic - https:/
xenial - https:/
trusty - https:/
To post a comment you must log in.
Looks fine.
Comments inline. The biggest change is I think that the version check would be better done on the mongo version rather than the OS version, but that doesn't need to block this landing and can be done easily enough in a followup branch.