~tcuthbert/charm-k8s-wordpress:additional_hostnames

Branch merges

Propose for merging

Merged into charm-k8s-wordpress:master at revision 15142081bbd9396aa0b66ba97fbaec1ae8033877

Tom Haddon: Approve on 2021-01-14

Canonical IS Reviewers: Pending requested 2021-01-13

Diff: 173 lines (+94/-0)

4 files modified

config.yaml (+4/-0)
src/charm.py (+30/-0)
tests/unit/test_charm.py (+59/-0)
tests/unit/test_wordpress.py (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

53bdaae... by Thomas Cuthbert on 2021-01-14

Updates based on review feedback

    * split_additional_hostnames wasn't named very well, made it more
      generalised and updated it with a naming convention that properly describes its job.
    * Removed superfluous inline comment for the is_valid_config method.
    * Be consistent with the additional_hostnames variable name.
    * The test for additional_hostnames was flawed due to charm config
      not being restored.
    * Added a test for when additional_hostnames is empty.

73e5665... by Thomas Cuthbert on 2021-01-13

Fix the TLS make resources tests so they support additional hostnames

e81f94e... by Thomas Cuthbert on 2020-12-31

Support sites with multiple hostnames ie fridge.u.c / ubuntu-news.org

8ed66e1... by Tom Haddon on 2021-01-12

Fix docker entrypoint to work for bionic or focal

Reviewed-on: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/396179
Reviewed-by: Laurent Sesques <email address hidden>

2fa252d... by Tom Haddon on 2021-01-12

Fix docker entrypoint to work for bionic or focal

f71d95f... by Tom Haddon on 2021-01-12

Add an action to retrieve initial password

Reviewed-on: https://code.launchpad.net/~mthaddon/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395982
Reviewed-by: Stuart Bishop <email address hidden>

0b3c464... by Tom Haddon on 2021-01-12

Fix merge conflicts

a169343... by Tom Haddon on 2021-01-12

Implement a MySQL database relation

The database connection details from the relation will
override any provided in the charm configuration.

Reviewed-on: https://code.launchpad.net/~stub/charm-k8s-wordpress/+git/charm-k8s-wordpress/+merge/395826
Reviewed-by: Stuart Bishop <email address hidden>

4930598... by Stuart Bishop on 2021-01-12

Docstrings

c2a1301... by Stuart Bishop on 2021-01-12

Fix tests