charm-k8s-mattermost

Merge ~tcuthbert/charm-k8s-mattermost:mm-poll into charm-k8s-mattermost:master

  1. Git
  2. lp:~tcuthbert/charm-k8s-mattermost
  3. mm-poll
  4. Merge into master
Proposed by Thomas Cuthbert
Status: Merged
Approved by: Thomas Cuthbert
Approved revision: dbdce443fbe5651a1bf0a5223febb5b58eb96368
Merged at revision: 20d16d67c8f69a686be3ed90b83895663fa63c5f
Proposed branch: ~tcuthbert/charm-k8s-mattermost:mm-poll
Merge into: charm-k8s-mattermost:master
Diff against target: 17 lines (+7/-0)
1 file modified
Dockerfile (+7/-0)
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Laurent Sesquès Approve
🤖 prod-jenkaas-is (community) continuous-integration Approve
Review via email: mp+399406@code.launchpad.net

Commit message

Add a MM poll plugin

Description of the change

I think this plugin would be useful for group consensus on MM discussions.

To post a comment you must log in.
Revision history for this message
🤖 prod-jenkaas-is (prod-jenkaas-is) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-is (prod-jenkaas-is) wrote :

PASSED: Continuous integration, rev:dbdce443fbe5651a1bf0a5223febb5b58eb96368
https://jenkins.canonical.com/is/job/lp-charm-k8s-mattermost-ci/1/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/is/job/lp-charm-test/24/
    None: https://jenkins.canonical.com/is/job/lp-update-mp/23663/

Click here to trigger a rebuild:
https://jenkins.canonical.com/is/job/lp-charm-k8s-mattermost-ci/1//rebuild

review: Approve (continuous-integration)
Revision history for this message
Laurent Sesquès (sajoupa) wrote :

not blocking on it, but it would be nice if we could make the path to the plugin point to the latest stable instead of pinning a specific one (which will need manual updates along going further)

review: Approve
Revision history for this message
Tom Haddon (mthaddon) wrote :

I agree with Laurent's comment, but we already do this for other plugins so I think this change is fine for now.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 20d16d67c8f69a686be3ed90b83895663fa63c5f

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index f348041..ec7e0aa 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -56,6 +56,13 @@ RUN if [ "$image_flavour" = canonical ]; then \
6 RUN if [ "$image_flavour" = canonical ]; then \
7 cd /mattermost/plugins && \
8 set -o pipefail && \
9+ curl -L https://github.com/matterpoll/matterpoll/releases/download/v1.4.0/com.github.matterpoll.matterpoll-1.4.0.tar.gz | tar -xvz ; \
10+ fi
11+
12+# Download and enable third-party plugin
13+RUN if [ "$image_flavour" = canonical ]; then \
14+ cd /mattermost/plugins && \
15+ set -o pipefail && \
16 curl -L https://github.com/moussetc/mattermost-plugin-giphy/releases/download/v2.0.0/com.github.moussetc.mattermost.plugin.giphy-2.0.0.tar.gz | tar -xvz ; \
17 fi
18

Subscribers

People subscribed via source and target branches