Merge lp:~tcfox54-gmail/ubuntu/precise/gimp/add_quicklist into lp:ubuntu/precise/gimp

Proposed by Trenton Fox
Status: Work in progress
Proposed branch: lp:~tcfox54-gmail/ubuntu/precise/gimp/add_quicklist
Merge into: lp:ubuntu/precise/gimp
Diff against target: 12 lines (+5/-0)
1 file modified
desktop/gimp.desktop.in.in (+5/-0)
To merge this branch: bzr merge lp:~tcfox54-gmail/ubuntu/precise/gimp/add_quicklist
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Fixing
Michael Terry Needs Information
Ubuntu branches Pending
Review via email: mp+96947@code.launchpad.net

This proposal supersedes a proposal from 2012-02-22.

Description of the change

Adds a Unity Quicklist shortcut to GIMP's launcher for opening new instances of the editor.
Fixed the quicklist to meet specifications.

To post a comment you must log in.
Revision history for this message
Michael Hall (mhall119) wrote : Posted in a previous version of this proposal

Thanks so much for your submission!

Recently a new FreeDesktop.org specification[1] has been approved for providing desktop-agnostic shortcuts. The Quicklist documentation has been updated to coincide with this new spec[2].

Since this is now an official standard, and will benefit environments other than Unity, we encourage you to change your code to match. This will require the following changes:
1) Change "X-Ayatana-Desktop-Shortcuts" to just "Actions"
2) Change each section from "[<action> Shortcut Group]" to "[Desktop Action <action>]"
3) Remove "TargetEnvironment=Unity"
4) Change your Name= entry to use Title Case[3] (capitalizing important words)

Please update this merge proposal with these changes so they can be included in the upcoming release of Ubuntu. Please also make sure you submit them to the upstream developers so they can be included there in future versions.

[1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s08.html
[2] https://wiki.ubuntu.com/Unity/LauncherAPI#Quicklists
[3] http://en.wikipedia.org/wiki/Title_case#Headings_and_publication_titles

Revision history for this message
Sebastien Bacher (seb128) wrote : Posted in a previous version of this proposal

Setting to "Work in progress" please set back to "Needs review" when you update so it shows again on the sponsoring list

Revision history for this message
Michael Terry (mterry) wrote :

Is this useful? Why would I want to open a new window?

review: Needs Information
Revision history for this message
Sebastien Bacher (seb128) wrote :

Some technical issues as well there:
- the actions group should have a trailing ";"
- you need a "_" before Name so it's translatable
- was the bug sent to upstream?

review: Needs Fixing

Unmerged revisions

51. By Trenton Fox

Fix to Unity Quicklist

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'desktop/gimp.desktop.in.in'
2--- desktop/gimp.desktop.in.in 2009-08-31 10:24:10 +0000
3+++ desktop/gimp.desktop.in.in 2012-03-12 00:40:23 +0000
4@@ -16,3 +16,8 @@
5 X-GNOME-Bugzilla-OtherBinaries=gimp-@GIMP_APP_VERSION@
6 StartupNotify=true
7 MimeType=@MIME_TYPES@
8+Actions=New
9+
10+[Desktop Action New]
11+Name=Open a New Window
12+Exec=gimp -n

Subscribers

People subscribed via source and target branches

to all changes: