Merge ~tbmb/launchpad:update-links into launchpad:master

Proposed by Toto Bille
Status: Merged
Approved by: Thiago F. Pappacena
Approved revision: 63ba8a1313544f7dcfe0c5cb8f5998eb73535ff7
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~tbmb/launchpad:update-links
Merge into: launchpad:master
Diff against target: 26 lines (+2/-2)
2 files modified
lib/lp/app/browser/doc/base-layout.txt (+1/-1)
lib/lp/app/templates/ (+1/-1)
Reviewer Review Type Date Requested Status
Thiago F. Pappacena (community) Approve
Kristian Glass (community) Approve
Review via email:

Commit message

Update links to new careers page.

Description of the change

Update links to new careers page.

To post a comment you must log in.
Revision history for this message
Kristian Glass (doismellburning) :
review: Approve
Revision history for this message
Kristian Glass (doismellburning) wrote :


Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

I'll set the commit message and merge this one.

Thanks again, Toto!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/app/browser/doc/base-layout.txt b/lib/lp/app/browser/doc/base-layout.txt
2index ddf10c1..f9eb8b7 100644
3--- a/lib/lp/app/browser/doc/base-layout.txt
4+++ b/lib/lp/app/browser/doc/base-layout.txt
5@@ -150,7 +150,7 @@ Page Footers
6 Data privacy
7 Contact Launchpad Support /feedback
8 Blog
9- Careers
10+ Careers
11 System status
12 Get the code!
14diff --git a/lib/lp/app/templates/ b/lib/lp/app/templates/
15index 938d47d..175551d 100644
16--- a/lib/lp/app/templates/
17+++ b/lib/lp/app/templates/
18@@ -301,7 +301,7 @@
19 >Blog</a>
20 <tal:careers_link condition="not: features/baselayout.careers_link.disabled">
21 &nbsp;&bull;&nbsp;
22- <a href=""
23+ <a href=""
24 >Careers</a>
25 </tal:careers_link>
26 &nbsp;&bull;&nbsp;


People subscribed via source and target branches

to status/vote changes: